Re: Insight remote output doesn't output to console window immediately

[Jonathan Larmour <jlarmour@redhat.co.uk>]

James Ingham wrote:
> 
> Jonathan,
> 
>  > James Ingham wrote:
>  > >
>  > > Okay, check this in.
>  >
>  > Trunk, branch or both?
> 
> Both.  Maybe add a FIXME to the comment, since I often grep for FIXME
> when I am trying to figure out what I should do next (though as I
> said, this one is already on the short list.)

I've added a FIXME comment now.

>  >
>  > > As for the Changelog-gdbtk's.  They should be changed to just
>  > > ChangeLog - the gdbtk is historic; the C-code files used to live at
>  > > the top level, but since Insight couldn't be included in the FSF gdb
>  > > releases, we had to have separate ChangeLogs...
>  >
>  > Would you like me to rename those two then? Obviously not forgetting to
>  > remove all the change-log-default-name emacs variables. That would be trunk
>  > only of course.
> 
> That would be lovely, thanks.

I'll check in the attached patch to the trunk only once you say so. I added
ChangeLog entries:

2000-04-17  Jonathan Larmour  <jlarmour@redhat.co.uk>
 
        * ChangeLog-gdbtk: Renamed to ChangeLog
        * ChangeLog: New file
        * README.GDBTK: No need for changelog-default-name hint for Emacs
now

generic/ChangeLog
2000-04-17  Jonathan Larmour  <jlarmour@redhat.co.uk>
 
        * ChangeLog-gdbtk: Renamed to ChangeLog
        * ChangeLog: New file
        * gdbtk-cmds.c, gdbtk-hooks.c, gdbtk-variable.c, gdbtk-varobj.c,
        gdbtk-wrapper.h, gdbtk-wrapper.c, gdbtk.h, gdbtk.c: No need for
        changelog-default-name hint for Emacs now

I was tempted to just go ahead check this in, but I'm erring on the side of
caution.

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault
cvs server: ChangeLog is a new entry, no comparison available
cvs server: ChangeLog-gdbtk was removed, no comparison available
Index: README.GDBTK
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/README.GDBTK,v
retrieving revision 1.1.1.1
diff -u -5 -p -r1.1.1.1 README.GDBTK
--- README.GDBTK	2000/02/07 00:19:42	1.1.1.1
+++ README.GDBTK	2000/04/17 20:05:43
@@ -396,8 +396,5 @@ m68k-hp-hpux9.00:
 		. 
 		. 
 		. 
 
 
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
cvs server: generic/ChangeLog is a new entry, no comparison available
cvs server: generic/ChangeLog-gdbtk was removed, no comparison available
Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.6
diff -u -5 -p -r1.6 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	2000/04/03 21:29:00	1.6
+++ generic/gdbtk-cmds.c	2000/04/17 20:05:45
@@ -4698,10 +4698,6 @@ setup_architecture_data ()
 {
   /* don't trust REGISTER_BYTES to be zero. */
   old_regs = xmalloc (REGISTER_BYTES + 1);
   memset (old_regs, 0, REGISTER_BYTES + 1);
 }
-\f
 
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
Index: generic/gdbtk-hooks.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-hooks.c,v
retrieving revision 1.3
diff -u -5 -p -r1.3 gdbtk-hooks.c
--- generic/gdbtk-hooks.c	2000/04/03 21:29:00	1.3
+++ generic/gdbtk-hooks.c	2000/04/17 20:05:45
@@ -905,8 +905,6 @@ gdbtk_detach ()
   if (Tcl_Eval (gdbtk_interp, "gdbtk_detached") != TCL_OK)
     {
       report_error ();
     }
 }
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
+
Index: generic/gdbtk-variable.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-variable.c,v
retrieving revision 1.1.1.1
diff -u -5 -p -r1.1.1.1 gdbtk-variable.c
--- generic/gdbtk-variable.c	2000/02/07 00:19:42	1.1.1.1
+++ generic/gdbtk-variable.c	2000/04/17 20:05:46
@@ -2409,9 +2409,6 @@ java_value_of_variable (var, obj)
      gdb_variable *var;
      Tcl_Obj **obj;
 {
   return cplus_value_of_variable (var, obj);
 }
-\f
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
+
Index: generic/gdbtk-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v
retrieving revision 1.2
diff -u -5 -p -r1.2 gdbtk-varobj.c
--- generic/gdbtk-varobj.c	2000/03/13 21:51:45	1.2
+++ generic/gdbtk-varobj.c	2000/04/17 20:05:46
@@ -627,9 +627,6 @@ uninstall_variable (interp, varname)
      Tcl_Interp *interp;
      char *varname;
 {
   Tcl_DeleteCommand (interp, varname);
 }
-\f
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
+
Index: generic/gdbtk-wrapper.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v
retrieving revision 1.2
diff -u -5 -p -r1.2 gdbtk-wrapper.c
--- generic/gdbtk-wrapper.c	2000/02/24 03:11:47	1.2
+++ generic/gdbtk-wrapper.c	2000/04/17 20:05:46
@@ -826,11 +826,6 @@ wrap_get_current_frame (char *opaque_arg
   struct gdb_wrapper_arguments **args = (struct gdb_wrapper_arguments **) opaque_arg;
 
   (*args)->result = (char *) get_current_frame ();
   return 1;
 }
-\f
 
-
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
Index: generic/gdbtk-wrapper.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.h,v
retrieving revision 1.2
diff -u -5 -p -r1.2 gdbtk-wrapper.h
--- generic/gdbtk-wrapper.h	2000/02/24 03:11:47	1.2
+++ generic/gdbtk-wrapper.h	2000/04/17 20:05:46
@@ -73,9 +73,6 @@ extern gdb_result GDB_get_next_frame PAR
 extern gdb_result GDB_find_relative_frame PARAMS ((struct frame_info *fi,
 						   int *start,
 						   struct frame_info **result));
 extern gdb_result GDB_get_current_frame PARAMS ((struct frame_info **result));
 #endif /* GDBTK_WRAPPER_H */
-\f
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
+
Index: generic/gdbtk.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.c,v
retrieving revision 1.2
diff -u -5 -p -r1.2 gdbtk.c
--- generic/gdbtk.c	2000/04/14 08:04:46	1.2
+++ generic/gdbtk.c	2000/04/17 20:05:46
@@ -528,11 +528,12 @@ gdbtk_find_main";
 
     /* fputs_unfiltered_hook = NULL; *//* Force errors to stdout/stderr */
 
     fputs_unfiltered_hook = gdbtk_fputs;
 
-    /* set gdb_stdtarg for now until gdbtk is changed to use struct ui_out. */
+    /* FIXME: set gdb_stdtarg for now until gdbtk is changed to use
+       struct ui_out. */
 
     gdb_stdtarg = gdb_stdout;
 
     if (Tcl_GlobalEval (gdbtk_interp, (char *) script) != TCL_OK)
       {
@@ -653,9 +654,6 @@ tk_command (cmd, from_tty)
 
   printf_unfiltered ("%s\n", result);
 
   do_cleanups (old_chain);
 }
-\f
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */
+
Index: generic/gdbtk.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.h,v
retrieving revision 1.2
diff -u -5 -p -r1.2 gdbtk.h
--- generic/gdbtk.h	2000/04/03 21:29:00	1.2
+++ generic/gdbtk.h	2000/04/17 20:05:46
@@ -178,9 +178,5 @@ extern void
 
 /* gdbtk_add_hooks - add all the hooks to gdb.  This will get called
    by the startup code to fill in the hooks needed by core gdb. */
 extern void gdbtk_add_hooks (void);
 
-\f
-/* Local variables: */
-/* change-log-default-name: "ChangeLog-gdbtk" */
-/* End: */