From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: insight@sourceware.cygnus.com, sbjohnson@ozemail.com.au Subject: FYI: Fix to Steven's 1st core dump - 2nd part Date: Tue, 17 Oct 2000 13:10:00 -0000 Message-id: <39ECB241.49EBA343@cygnus.com> References: <39E786E1.CD82D259@cygnus.com> X-SW-Source: 2000-q4/msg00083.html This is an Insight fix, instead of the gdb fix that Steven has already tested. It worked for me with the other problem that I mentioned (with very different symptoms but nevertheless related to this one). If it works for Steven, i.e., if he uses this patch in lieu of the patch to ser-unix.c and does not get core dumps (or any other malfunction), we should add this patch to the insight sources and leave gdb alone. Steven: thanks a lot for doing this tests! -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9 Index: gdbtk/generic/gdbtk-hooks.c =================================================================== RCS file: /cvs/cvsfiles/devo/gdb/gdbtk/generic/gdbtk-hooks.c,v retrieving revision 1.4 diff -c -p -r1.4 gdbtk-hooks.c *** gdbtk-hooks.c 2000/05/01 04:46:49 1.4 --- gdbtk-hooks.c 2000/10/17 20:03:12 *************** x_event (signo) *** 416,422 **** --- 416,432 ---- static volatile int in_x_event = 0; static Tcl_Obj *varname = NULL; static int count = 0; + + /* Do nor re-enter this code or enter it while collecting gdb output. */ if (in_x_event || in_fputs) + return 0; + + /* Also, only do things while the target is running (stops and redraws). + FIXME: We wold like to at least redraw at other times but this is bundled + together in the TCL_WINDOW_EVENTS group and we would also process user + input. We will have to prevent (unwanted) user input to be generated + in order to be able to redraw (removing this test here). */ + if (!running_now) return 0; in_x_event = 1;