From: Fernando Nasser <fnasser@cygnus.com>
To: lsmith@redhat.com
Cc: Syd Polk <spolk@redhat.com>, insight@sources.redhat.com
Subject: Re: [RFA] 100494 fix
Date: Tue, 31 Oct 2000 11:22:00 -0000 [thread overview]
Message-ID: <39FF1BF6.67417925@cygnus.com> (raw)
In-Reply-To: <39FF0A48.5F8440DC@smith-house.org>
Nice work Larry.
But please rename run_method to rm_method (like rm_frame).
This way we do not confuse the state variables that indicate weather
we want to run or continue (run_run and run_cont) and the variables
that contain window paths.
Another thing: Your patch seem to have a mix of "diff" and "cvs diff".
"patch" didn't like it. I had to hand edit it several times in order
to try it.
cvs diff is the preferable method. Unless the contributor does not have
a cvs tree, the patch should be created by a cvs diff.
Thanks for the patch.
Regards,
Fernando
Larry Smith wrote:
>
> 2000-10-31 Larry Smith <lsmith@redhat.com>
>
> * change targetselection.it*, put Run Program and Continue
> From...
> buttons into a frame and disables both of them when the target
> is
> "exec".
>
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.ith,v
> retrieving revision 1.2
> diff -r1.2 targetselection.ith
> 57a58,59
> >
> > variable run_method
> >
>
> > cvs diff -r 1.5 targetselection.itb
> Index: targetselection.itb
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/targetselection.itb,v
> retrieving revision 1.5
> diff -r1.5 targetselection.itb
> 489a490,493
> > set rm_frame [iwidgets::labeledframe $frame.run_method -labelpos nw -labeltext "Run Method" ]
> > set run_method [ $rm_frame childsite ]
> >
> > set rm_label [label $frame.label -text "Run Method:"]
> 491c495
> < radiobutton $frame.cont -text {Continue from Last Stop} -value 1
> -variable $var \
> ---
> > radiobutton $run_method.cont -text {Continue from Last Stop} -value 1 -variable $var \
> 495c499
> < radiobutton $frame.run -text {Run Program} -value 1 -variable $var \
> ---
> > radiobutton $run_method.run -text {Run Program} -value 1 -variable $var \
> 501,504c505,516
> < grid $frame.attach $frame.run -sticky w
> < grid $frame.load $frame.cont -sticky w
> < grid $frame.afterl -sticky we -columnspan 2
> < grid $frame.aftere -sticky we -columnspan 2
> ---
> >
> > grid $frame.label -column 1 -row 0 -sticky w
> > grid $frame.attach -column 0 -row 1 -ipady 2
> > grid $frame.load -column 0 -row 2 -ipady 2
> >
> > grid $run_method.run -column 0 -row 1 -sticky w -ipady 2
> > grid $run_method.cont -column 0 -row 2 -sticky w -ipady 2
> >
> > grid $rm_frame -column 1 -row 1 -rowspan 2 -sticky nsew -ipady 2
> >
> > grid $frame.afterl -row 4 -sticky we -columnspan 2 -ipady 2
> > grid $frame.aftere -sticky we -columnspan 2 -ipady 2
> 724a737,745
> >
> > if { "$target" == "exec" } {
> > $run_method.run configure -state disabled -value 1
> > $run_method.cont configure -state disabled
> > } else {
> > $run_method.run configure -state normal
> > $run_method.cont configure -state normal
> > }
>
> --
> .-. .-. .---. .---. .-..-. | "Bill Gates is just a monocle
> | |__ / | \| |-< | |-< > / | and a Persian Cat away from
> `----'`-^-'`-'`-'`-'`-' `-' | being one of the bad guys in a
> My opinions only. | James Bond movie." -- D Miller
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
next prev parent reply other threads:[~2000-10-31 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200010272126.RAA02584@ozma.smith-house.org>
2000-10-30 12:53 ` Fernando Nasser
2000-10-30 15:45 ` Larry Smith
2000-10-31 9:19 ` Larry Smith
2000-10-31 9:23 ` Syd Polk
2000-10-31 10:06 ` Larry Smith
2000-10-31 10:33 ` Syd Polk
2000-10-31 10:51 ` Fernando Nasser
2000-10-31 11:23 ` Larry Smith
2000-10-31 11:30 ` Syd Polk
2000-10-31 11:22 ` Fernando Nasser [this message]
2000-10-31 11:42 Larry Smith
2000-10-31 12:06 ` Fernando Nasser
2000-10-31 12:10 ` Syd Polk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39FF1BF6.67417925@cygnus.com \
--to=fnasser@cygnus.com \
--cc=insight@sources.redhat.com \
--cc=lsmith@redhat.com \
--cc=spolk@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).