From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: insight@sources.redhat.com
Cc: Kevin Buettner <kevinb@cygnus.com>
Subject: Re: [PATCH] Add type parameter to set_raw_breakpoint()
Date: Sat, 12 May 2001 20:54:00 -0000
Message-id: <3AFCD040.30009@cygnus.com>
References: <1010511200742.ZM28831@ocotillo.lan>
X-SW-Source: 2001-q2/msg00240.html

> I've just committing the following changes.  For more information on the
> corresponding changes to breakpoint.c, see:
> 
>     http://sources.redhat.com/ml/gdb-patches/2001-05/msg00204.html
> 
> Please note that set_raw_breakpoint() ought to either be declared
> extern in breakpoint.h or calls to this function should be removed from
> gdbtk-bp.c so that it can be made static in breakpoint.c.

It should be static.  Insight should instead call the published interface:

/* Create a breakpoint at ADDRESS (a GDB source and line). */
enum gdb_rc gdb_breakpoint (char *address, char *condition,
                             int hardwareflag, int tempflag,
                             int thread, int ignore_count);

	Andrew