public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Ian Roxborough <irox@redhat.com>
To: Keith Seitz <keiths@cygnus.com>
Cc: insight@sources.redhat.com
Subject: Re: [RFA] Set path to iwidgets.
Date: Mon, 10 Sep 2001 12:18:00 -0000	[thread overview]
Message-ID: <3B9D1201.C01AEE3F@redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.33.0109101209300.1665-100000@makita.cygnus.com>

2001-09-10  Ian Roxborough <irox@redhat.com>

	* generic/gdbtk.c (gdbtk_init): Set IWIDGETS_LIBRARY if
          Insight is launched from within the build directory.
	* library/util.tcl (find_iwidgets_library): Removed.
	* library/main.tcl: Don't call find_iwidgets_library, do a
	  package require instead.

Keith Seitz wrote:
> 1) Need "library/" prefix on util.tcl and main.tcl.

Duh!

> 2) The patches are related, so please remove newlines between changelog
> entries before committing. Only put newlines when the changes are not
> related (see GNU coding standard on this). Yeah, it's stupid, but it's
> something that I've grown accustomed to looking at in ChangeLogs now.

Sounds good to me.  

I'll check in the patch then,

Thanks,
Ian.

  reply	other threads:[~2001-09-10 12:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-10 12:02 Ian Roxborough
2001-09-10 12:12 ` Keith Seitz
2001-09-10 12:18   ` Ian Roxborough [this message]
2001-09-10 12:26     ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B9D1201.C01AEE3F@redhat.com \
    --to=irox@redhat.com \
    --cc=insight@sources.redhat.com \
    --cc=keiths@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).