From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2495 invoked by alias); 26 Feb 2002 03:57:50 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 2276 invoked from network); 26 Feb 2002 03:57:42 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 26 Feb 2002 03:57:42 -0000 Received: from redhat.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id TAA03404 for ; Mon, 25 Feb 2002 19:57:39 -0800 (PST) Message-ID: <3C7B193E.DE3E35EA@redhat.com> Date: Mon, 25 Feb 2002 19:57:00 -0000 From: Ian Roxborough X-Mailer: Mozilla 4.61 [en] (X11; I; Linux 2.2.14 i686) X-Accept-Language: en MIME-Version: 1.0 To: insight@sources.redhat.com Subject: Patch: Fix Windows Crashing. Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-q1/txt/msg00168.txt.bz2 Hi, if you recall many months a go I report a Windows crasher the was related the using comboboxes in modal dialogs. I'm finally near a fix that I'd like to checkin. The problem seems to be in the combobox (well ok, it's in Tk really), it makes the popup part of the combobox a "redirectoverride" window, then it makes the popup a "transient" window. Tk does a "window in window" trick to do both of these and some where it along the line it doesn't clean up after itself. Notes: a Tk toplevel can be "normal", "redirectoverride" or "transient", it cannot be more than one at a time (or so the source code leads me to believe). You should be able to change between these freely, undoing the properties of the previous settings. The real bug is that changing from a "redirectoverride" to a "transient" window some how is broken (while a grab is in effect). At some point I'd like to find out more about why. This patch removes the "transient" window part and everything seems to work fine. I'd like to hear from some other people using Windows before I ask to check it in. Well, I'm pretty happy to be making head way on this problem (I've spent months working at this!)... Ian. Index: libgui/library/combobox.tcl =================================================================== RCS file: /cvs/src/src/libgui/library/combobox.tcl,v retrieving revision 1.2 diff -u -2 -r1.2 combobox.tcl --- combobox.tcl 2001/09/08 22:34:46 1.2 +++ combobox.tcl 2002/02/26 03:34:03 @@ -217,5 +217,4 @@ # do some window management foo. wm overrideredirect $widgets(popup) 1 - wm transient $widgets(popup) [winfo toplevel $this] wm group $widgets(popup) [winfo parent $this] wm resizable $widgets(popup) 0 0