Re: GDB CVS won't build on OSF4.0's cc

[Andrew Cagney <ac131313@cygnus.com>]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

[added insight]

> On May 29, 2001, Alexandre Oliva <aoliva@redhat.com> wrote:
> 
> 
>> Another problem showed up while building gdbtk.  gdb/defs.h #includes
>> <stdarg.h>, but tcl/generic/tclInt.h #includes <varargs.h>, because
>> HAS_STDARG is not defined.
> 
> 
>> It turns out that the va_start macro defined in varargs.h ends up
>> overriding that of stdarg.h, so we call va_start with the wrong number
>> of arguments.
> 
> 
>> Since GDB assumes the existence of stdarg.h, I suppose this patch
>> would be acceptable.  Ok to install?
> 
> 
> This one seems to have never been acknowledged.  Ok for 5.2 and
> mainline?

I don't know that this belongs in defs.h (definitly not without a big 
comment explaining the history :-).  As you note, gdb doesn't include 
tclInt.h, only GDBTK.  I suspect gdbtk/generic/gdbtk.h or autoconf is 
better?

Andrew


[-- Attachment #2: mailbox-message://ac131313@movemail/fsf/gdb/patches#899876 --]
[-- Type: message/rfc822, Size: 4176 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 574 bytes --]

On May 29, 2001, Alexandre Oliva <aoliva@redhat.com> wrote:

> Another problem showed up while building gdbtk.  gdb/defs.h #includes
> <stdarg.h>, but tcl/generic/tclInt.h #includes <varargs.h>, because
> HAS_STDARG is not defined.

> It turns out that the va_start macro defined in varargs.h ends up
> overriding that of stdarg.h, so we call va_start with the wrong number
> of arguments.

> Since GDB assumes the existence of stdarg.h, I suppose this patch
> would be acceptable.  Ok to install?

This one seems to have never been acknowledged.  Ok for 5.2 and
mainline?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: gdb-has-stdarg.patch --]
[-- Type: text/x-patch, Size: 513 bytes --]

Index: gdb/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* defs.h (HAS_STDARG): Define it.

Index: gdb/defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.50
diff -u -p -r1.50 defs.h
--- gdb/defs.h 2001/05/15 00:03:36 1.50
+++ gdb/defs.h 2001/05/29 11:10:38
@@ -54,6 +54,7 @@
 #include "ansidecl.h"
 
 #include <stdarg.h>		/* for va_list */
+#define HAS_STDARG 1		/* Avoid varargs.h in tcl.  */
 
 #include "libiberty.h"
 

[-- Attachment #2.1.3: Type: text/plain, Size: 289 bytes --]


-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer