From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17442 invoked by alias); 7 Mar 2002 01:58:07 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 17360 invoked from network); 7 Mar 2002 01:58:04 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.135.44) by sources.redhat.com with SMTP; 7 Mar 2002 01:58:04 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E2D593D1D; Wed, 6 Mar 2002 20:57:59 -0500 (EST) Message-ID: <3C86C927.4070601@cygnus.com> Date: Wed, 06 Mar 2002 17:58:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.8) Gecko/20020210 X-Accept-Language: en-us MIME-Version: 1.0 To: Alexandre Oliva Cc: gdb-patches@sources.redhat.com, insight@sources.redhat.com Subject: Re: GDB CVS won't build on OSF4.0's cc References: Content-Type: multipart/mixed; boundary="------------060300010001060306010603" X-SW-Source: 2002-q1/txt/msg00183.txt.bz2 This is a multi-part message in MIME format. --------------060300010001060306010603 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 855 [added insight] > On May 29, 2001, Alexandre Oliva wrote: > > >> Another problem showed up while building gdbtk. gdb/defs.h #includes >> , but tcl/generic/tclInt.h #includes , because >> HAS_STDARG is not defined. > > >> It turns out that the va_start macro defined in varargs.h ends up >> overriding that of stdarg.h, so we call va_start with the wrong number >> of arguments. > > >> Since GDB assumes the existence of stdarg.h, I suppose this patch >> would be acceptable. Ok to install? > > > This one seems to have never been acknowledged. Ok for 5.2 and > mainline? I don't know that this belongs in defs.h (definitly not without a big comment explaining the history :-). As you note, gdb doesn't include tclInt.h, only GDBTK. I suspect gdbtk/generic/gdbtk.h or autoconf is better? Andrew --------------060300010001060306010603 Content-Type: message/rfc822; name="mailbox-message://ac131313@movemail/fsf/gdb/patches#899876" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mailbox-message://ac131313@movemail/fsf/gdb/patches#899876" Content-length: 4116 X-Mozilla-Status2: 10000000 Return-Path: Delivered-To: ac131313@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BCB703E68 for ; Wed, 6 Mar 2002 20:09:20 -0500 (EST) Received: from pop.cygnus.com by localhost with IMAP (fetchmail-5.9.6) for ac131313@localhost (single-drop); Wed, 06 Mar 2002 20:09:20 -0500 (EST) Received: from sources.redhat.com (sources.redhat.com [209.249.29.67]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id QAA25962 for ; Wed, 6 Mar 2002 16:12:56 -0800 (PST) Received: (qmail 26930 invoked by alias); 7 Mar 2002 00:12:51 -0000 Received: (qmail 26876 invoked from network); 7 Mar 2002 00:12:51 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 7 Mar 2002 00:12:51 -0000 Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA25939 for ; Wed, 6 Mar 2002 16:12:50 -0800 (PST) Received: from free.redhat.lsd.ic.unicamp.br (vpnuser.sfbay.redhat.com [10.255.17.130] (may be forged)) by cse.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id QAA11991 for ; Wed, 6 Mar 2002 16:12:49 -0800 (PST) Received: (from aoliva@localhost) by free.redhat.lsd.ic.unicamp.br (8.11.6/8.11.6) id g270CmR14846; Wed, 6 Mar 2002 21:12:48 -0300 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com To: gdb-patches@sources.redhat.com Subject: Re: GDB CVS won't build on OSF4.0's cc References: From: Alexandre Oliva Organization: GCC Team, Red Hat Date: 06 Mar 2002 21:12:47 -0300 In-Reply-To: Alexandre Oliva's message of "29 May 2001 08:12:47 -0300" Message-ID: User-Agent: Gnus/5.0805 (Gnus v5.8.5) Emacs/20.7 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-length: 574 On May 29, 2001, Alexandre Oliva wrote: > Another problem showed up while building gdbtk. gdb/defs.h #includes > , but tcl/generic/tclInt.h #includes , because > HAS_STDARG is not defined. > It turns out that the va_start macro defined in varargs.h ends up > overriding that of stdarg.h, so we call va_start with the wrong number > of arguments. > Since GDB assumes the existence of stdarg.h, I suppose this patch > would be acceptable. Ok to install? This one seems to have never been acknowledged. Ok for 5.2 and mainline? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gdb-has-stdarg.patch Content-length: 513 Index: gdb/ChangeLog from Alexandre Oliva * defs.h (HAS_STDARG): Define it. Index: gdb/defs.h =================================================================== RCS file: /cvs/src/src/gdb/defs.h,v retrieving revision 1.50 diff -u -p -r1.50 defs.h --- gdb/defs.h 2001/05/15 00:03:36 1.50 +++ gdb/defs.h 2001/05/29 11:10:38 @@ -54,6 +54,7 @@ #include "ansidecl.h" #include /* for va_list */ +#define HAS_STDARG 1 /* Avoid varargs.h in tcl. */ #include "libiberty.h" --=-=-= Content-length: 289 -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC Developer aoliva@{cygnus.com, redhat.com} CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} Free Software Evangelist Professional serial bug killer --=-=-=-- --------------060300010001060306010603--