From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-3672-listarch-insight=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 9817 invoked by alias); 13 Sep 2002 19:22:51 -0000
Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:insight-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/insight/>
List-Post: <mailto:insight@sources.redhat.com>
List-Help: <mailto:insight-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: insight-owner@sources.redhat.com
Received: (qmail 9801 invoked from network); 13 Sep 2002 19:22:50 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 13 Sep 2002 19:22:50 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id DF3393C96; Fri, 13 Sep 2002 15:22:47 -0400 (EDT)
Message-ID: <3D823B07.1060302@ges.redhat.com>
Date: Fri, 13 Sep 2002 12:22:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Keith Seitz <keiths@redhat.com>
Cc: Mo DeJong <supermo@bayarea.net>,
	Insight <insight@sources.redhat.com>
Subject: Re: Patch to avoid using mkfifo under Cygwin
References: <Pine.LNX.4.44.0209130746340.1407-100000@valrhona.uglyboxes.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-q3/txt/msg00159.txt.bz2

> On Thu, 12 Sep 2002, Mo DeJong wrote:
> 
> 
>> Here is a patch that avoids calling mkfifo under Cygwin since
>> it is not functional.
> 
> 
> Ok, so given cgf's latest comments, do we want to hold off on this or 
> revert it when the cygwin work is ready? Maybe we can write an autoconf 
> test for it?

What about the 5.3 branch?

Andrew


>> 2002-09-12  Mo DeJong  <supermo@bayarea.net>
>> 
>> 	* unix/tclUnixFCmd.c (DoCopyFile): Don't use mkfifo
>> 	when compiling with Cygwin, since it is not supported.
>> 
>> Index: unix/tclUnixFCmd.c
>> ===================================================================
>> RCS file: /cvs/src/src/tcl/unix/tclUnixFCmd.c,v
>> retrieving revision 1.2
>> diff -u -r1.2 tclUnixFCmd.c
>> --- unix/tclUnixFCmd.c	9 Sep 2001 23:56:09 -0000	1.2
>> +++ unix/tclUnixFCmd.c	12 Sep 2002 22:37:10 -0000
>> @@ -391,12 +391,18 @@
>>  	    }
>>  	    return CopyFileAtts(src, dst, &srcStatBuf);
>>  	}
>> +#ifndef __CYGWIN__
>> +        /*
>> +         * mkfifo is not supported under Cygwin even though it is prototyped
>> +         * in newlib headers.
>> +         */
>>          case S_IFIFO: {
>>  	    if (mkfifo(dst, srcStatBuf.st_mode) < 0) {	/* INTL: Native. */
>>  		return TCL_ERROR;
>>  	    }
>>  	    return CopyFileAtts(src, dst, &srcStatBuf);
>>  	}
>> +#endif /* __CYGWIN__ */
>>          default: {
>>  	    return CopyFile(src, dst, &srcStatBuf);
>>  	}
>> 
> 
> 
>