From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15080 invoked by alias); 25 Sep 2002 05:04:41 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 15073 invoked from network); 25 Sep 2002 05:04:41 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 25 Sep 2002 05:04:41 -0000 Received: from redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 0541980022F; Wed, 25 Sep 2002 01:04:40 -0400 (EDT) Message-ID: <3D91438F.8080005@redhat.com> Date: Tue, 24 Sep 2002 22:04:00 -0000 From: Fernando Nasser Organization: Red Hat Canada User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Martin M. Hunt" Cc: insight@sources.redhat.com Subject: Re: Modal Dialogs lose grab when comboboxes are used References: <3D88E72F.3040406@redhat.com> <3D88F595.1040902@redhat.com> <3D912A47.5060302@redhat.com> Content-Type: multipart/mixed; boundary="------------000701060101090005050904" X-SW-Source: 2002-q3/txt/msg00190.txt.bz2 This is a multi-part message in MIME format. --------------000701060101090005050904 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 505 Ouch! There is indeed a line missing from my patch. I've committed the attached. Thanks for spotting it Martin. Fernando Martin M. Hunt wrote: > Fernando, > > Did you forget something? This breaks all the comboboxes on Insight. > Looks like grabstatus is not initialized. Doing that gets things > working for me, but I did not look very closely. > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9 --------------000701060101090005050904 Content-Type: text/plain; name="COMBOBOX2.PATCH" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="COMBOBOX2.PATCH" Content-length: 670 Index: library/combobox.tcl =================================================================== RCS file: /cvs/src/src/libgui/library/combobox.tcl,v retrieving revision 1.4 retrieving revision 1.5 diff -c -p -r1.4 -r1.5 *** library/combobox.tcl 20 Sep 2002 17:38:52 -0000 1.4 --- library/combobox.tcl 25 Sep 2002 05:01:21 -0000 1.5 *************** proc ::combobox::widgetProc {w command a *** 792,797 **** --- 792,798 ---- # *gasp* do a global grab!!! Mom always told not to # do things like this... :-) set grablist [grab current] + set grabstatus {} foreach grabitem $grablist { lappend grabstatus [grab status $grabitem] } --------------000701060101090005050904--