From: Andrew Cagney <ac131313@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Pierre Muller <muller@cerbere.u-strasbg.fr>,
gdb-patches@sources.redhat.com, insight@sources.redhat.com
Subject: Re: Problem about insight rename patch
Date: Mon, 21 Oct 2002 12:08:00 -0000 [thread overview]
Message-ID: <3DB440B0.70003@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0210030843400.1509-100000@valrhona.uglyboxes.com>
>> Basically removing
>> _initialize_gdbtk from init.c
>> does not prevent gdb from compiling,
>> so the only reason why I didn't send a patch proposal
>> is that I don't know the correct way of fixing it?
>> Maybe separate init.c
>> into init.c and insight-init.c?
>> But there might be better solutions?
>
>
> I believe the proper way to do this (Andrew/others will step in and tell
> me if I'm barking up the wrong perverbial tree) is to create an
> init_chain, which holds callbacks to be made for initialization.
> insight-main.c could register _initialize_gdbtk to this chain and top.c
> would then call it when it was doing initializations. My initial plan was
> to submit a patch to do just this. Eventually we could investigate getting
> other initializations registered in main (or we could simple keep init.c).
>
> Or we could just create a new initialize_hook (yich) which main could set
> to get _initialize_gdbtk to run. Or we could just integrate
> _initialize_gdbtk into main(), or ...
Any / all of the above.
Similar issues arise with MI, TUI and CLI. The way init.c is created
could do with a re-think. Fortunatly it isn't causing any immediate pain.
One thing though, I think more of the files should always be added to
libgdb.a. I can't think of a reason for not including MI or CLI files
in the archive by default.
Andrew
prev parent reply other threads:[~2002-10-21 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0209270750050.1515-100000@valrhona.uglyboxes.com>
2002-09-28 8:16 ` 5.3 branch? Was: " Andrew Cagney
2002-10-03 0:59 ` Problem about " Pierre Muller
2002-10-03 8:54 ` Keith Seitz
2002-10-21 12:08 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB440B0.70003@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=insight@sources.redhat.com \
--cc=keiths@redhat.com \
--cc=muller@cerbere.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).