From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18667 invoked by alias); 27 Nov 2002 15:29:34 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 18650 invoked from network); 27 Nov 2002 15:29:32 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 27 Nov 2002 15:29:32 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3B2DA3F30; Wed, 27 Nov 2002 10:29:23 -0500 (EST) Message-ID: <3DE4E4D3.7020106@redhat.com> Date: Wed, 27 Nov 2002 07:29:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: insight@sources.redhat.com, nickk@ubicom.com Subject: [commit] deprecated_frame_in_dummy() to get_frame_type() Content-Type: multipart/mixed; boundary="------------090601020106070805040302" X-SW-Source: 2002-q4/txt/msg00123.txt.bz2 This is a multi-part message in MIME format. --------------090601020106070805040302 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 146 FYI, I committed the attached as pretty obvious. It should stop the panics that nickk reported (thanks!). (Nick, btw, I can count :-) Andrew --------------090601020106070805040302 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1773 2002-11-27 Andrew Cagney * generic/gdbtk-stack.c (get_frame_name): Use get_frame_type instead of deprecated_frame_in_dummy. * generic/gdbtk-cmds.c (gdb_loc): Ditto. Index: gdbtk/generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.60 diff -u -r1.60 gdbtk-cmds.c --- gdbtk/generic/gdbtk-cmds.c 19 Nov 2002 19:33:46 -0000 1.60 +++ gdbtk/generic/gdbtk-cmds.c 27 Nov 2002 15:25:25 -0000 @@ -2273,7 +2273,7 @@ sal = find_pc_line (selected_frame->pc, selected_frame->next != NULL && !(get_frame_type (selected_frame->next) == SIGTRAMP_FRAME) - && !deprecated_frame_in_dummy (selected_frame->next)); + && !(get_frame_type (selected_frame->next) == DUMMY_FRAME)); } else { Index: gdbtk/generic/gdbtk-stack.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v retrieving revision 1.12 diff -u -r1.12 gdbtk-stack.c --- gdbtk/generic/gdbtk-stack.c 24 Nov 2002 18:44:36 -0000 1.12 +++ gdbtk/generic/gdbtk-stack.c 27 Nov 2002 15:25:25 -0000 @@ -522,7 +522,7 @@ enum language funlang = language_unknown; Tcl_Obj *objv[1]; - if (deprecated_frame_in_dummy (fi)) + if (get_frame_type (fi) == DUMMY_FRAME) { objv[0] = Tcl_NewStringObj ("\n", -1); Tcl_ListObjAppendElement (interp, list, objv[0]); @@ -539,7 +539,7 @@ find_pc_line (fi->pc, fi->next != NULL && !(get_frame_type (fi) == SIGTRAMP_FRAME) - && !deprecated_frame_in_dummy (fi->next)); + && !(get_frame_type (fi) == DUMMY_FRAME)); func = find_pc_function (fi->pc); if (func) --------------090601020106070805040302 Content-Type: message/rfc822; name="mailbox-message://ac131313@movemail/fsf/gdb/misc#3495483" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mailbox-message://ac131313@movemail/fsf/gdb/misc#3495483" Content-length: 3611 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: ac131313@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0CF9A3FEB for ; Tue, 26 Nov 2002 21:13:20 -0500 (EST) Envelope-to: cagney@gnu.org Delivery-date: Tue, 26 Nov 2002 20:17:47 -0500 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-5.9.13) for ac131313@localhost (single-drop); Tue, 26 Nov 2002 21:13:20 -0500 (EST) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.10) id 18Gqpn-00024W-02 for cagney@gnu.org; Tue, 26 Nov 2002 20:17:47 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 18Gqph-0006Ns-00 for cagney@gnu.org; Tue, 26 Nov 2002 20:17:42 -0500 Received: from sources.redhat.com ([209.249.29.67]) by monty-python.gnu.org with smtp (Exim 4.10) id 18Gqph-0006NW-00 for cagney@gnu.org; Tue, 26 Nov 2002 20:17:41 -0500 Received: (qmail 18847 invoked by alias); 27 Nov 2002 01:17:36 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Delivered-To: mailing list gdb@sources.redhat.com Received: (qmail 18835 invoked from network); 27 Nov 2002 01:17:35 -0000 Received: from unknown (HELO sccrmhc01.attbi.com) (204.127.202.61) by sources.redhat.com with SMTP; 27 Nov 2002 01:17:35 -0000 Received: from nkelseyhome (12-235-58-117.client.attbi.com[12.235.58.117]) by sccrmhc01.attbi.com (sccrmhc01) with SMTP id <2002112701173400100qrvuve>; Wed, 27 Nov 2002 01:17:34 +0000 Message-ID: <001b01c295b2$c2ec0440$0a00a8c0@nkelseyhome> From: "Nick Kelsey" To: Subject: Change to breakpoint.c breaks insight on trunk Date: Tue, 26 Nov 2002 17:17:31 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 X-Spam-Status: Yes, hits=6.1 required=5.0 tests=INVALID_MSGID,PRIORITY_NO_NAME,RCVD_IN_MULTIHOP_DSBL, RCVD_IN_UNCONFIRMED_DSBL,SPAM_PHRASE_00_01 version=2.41 X-Spam-Flag: YES X-Spam-Level: ****** X-Spam-Checker-Version: SpamAssassin 2.41 (1.115.2.8-2002-09-05-exp) X-Spam-Report: 6.10 hits, 5 required; * 1.2 -- Message-Id is not valid, according to RFC 2822 * 0.6 -- BODY: Spam phrases score is 00 to 01 (low) * 0.8 -- RBL: Received via a relay in multihop.dsbl.org [RBL check: found 61.202.127.204.multihop.dsbl.org] * 0.8 -- RBL: Received via a relay in unconfirmed.dsbl.org [RBL check: found 61.202.127.204.unconfirmed.dsbl.org] * 2.7 -- Message has priority setting, but no X-Mailer Content-length: 467 Hi all, Recently a new debug assert was added: /* This function is used by two files: get_frame_type(), after first checking that !USE_GENERIC_DUMMY_FRAMES; and sparc-tdep.c, which doesn't yet use generic dummy frames anyway. */ gdb_assert (!USE_GENERIC_DUMMY_FRAMES); It is also used by gdbtk-cmds.c and gdbtk-stack.c - someone can't count :-) For targets where USE_GENERIC_DUMMY_FRAMES is used, insight trips up on the assert every time. Nick --------------090601020106070805040302--