From: Andrew Cagney <ac131313@redhat.com>
To: Ruppert <ru@swb.siemens.de>
Cc: insight@sources.redhat.com
Subject: Re: Unable to restore previously selected frame: Observations
Date: Thu, 28 Nov 2002 20:15:00 -0000 [thread overview]
Message-ID: <3DE6E9BC.1000702@redhat.com> (raw)
In-Reply-To: <200211131719.gADHJYu14688@haiti.swb.siemens.de>
I suspect it's insight@. Switching list back :-)
> about two weeks ago I posted the following note to insight@sorces.redhat.com.
> It deals with a bogus "Unable to restore previously selected frame" warning
> which seems to occur randomly when a function call is made from the
> gdb/insight console.
>
> I found one reason for this; and because it is more a gdb issue than a
> insight issue I thought these observations might be useful:
Can you try reproducing this with more up-to-date sources (preferably
those from the mainline). See:
ftp://sources.redhat.com/pub/gdb/snapshots/current/
The frame code is currently undergoing ongoing radical reform.
Consequently, this problem may or may not still be present. The global
variable `selected_frame_level' that you refered to, for instance, has gone.
Andrew
>> I apologize if this is a "known glitch" or if this is considered
>> only a minor problem, but I think that I have made some
>> observations which might be useful to somebody who cares about
>> this kind of things:
>>
>> I am in the process of adapting insight 5.1 to a target monitor,
>> and in doing this I have often encountered this popup window "Unable to
>> restore previously selected frame". This happens quite often, but not
>> always when I manually enter a function call in insight/gdb.
>>
>> Accidentally I noted that this happens _always_ after I looked
>> for a variable value with the balloon evaluator in insight. The
>> sequence
>>
>> - put the cursor on some variable name and wait for the
>> balloon evaluator window which displays the value
>> - manually enter some function call into the console window
>>
>> reliably results in this "Unable to restore..." popup.
>>
>> This does not happen when a variable is printed directly in the
>> console window.
>>
>> To be sure that I did not inadvertedly mess up something I tried
>> to do this on a plain vanilla Linux box (also with insight 5.1),
>> and there I see the same behaviour. From this I conclude that this
>> is a genuine insight (or probably gdb) issue.
>>
>> I poked around a bit with a debugger and found the following:
>>
>> - this is triggered in restore_selected_frame always by the value -1
>> in the variable "level".
>> - this value gets there in the following way:
>> - the balloon evaluator invokes varobj_create, and there select_frame
>> is invoked with -1 given as level argument.
>> - select_frame puts this in the global variable selected_frame_level
>> - a manual function call results in the following:
>> save_inferior_status
>> record_selected_frame
>> here the value of selected_frame_level is copied into
>> inferior_status->selected_level
>> ... function call ...
>> restore_inferior_status
>> restore_selected_frame
>> here the value of selected_level is extracted from the
>> inferior_status structure and find_relative_frame invoked.
>> This leaves that "level" -1 intact, which leads to the
>> warning because of the condition "level != 0".
>>
>> I think this explains the (or at least one) sequence of events which
>> leads to this popup.
>>
>> I don't know much about the code in question, but could this be avoided
>> by not noting the value -1 in the global variable selected_frame_level in
>> function select_frame? "Real" level values are obviously always >= 0, and
>> it may not be reasonable to note this "artificial" level value (-1 seems
>> to mean "unknown level").
>>
>>
>> This may, after all, be considered only a cosmetic issue. But at least
>> it is a bit annoying, and it results in a bogus warning, which may be
>> taken for serious.
>>
>>
>> Regards
>> Dieter Ruppert
>> RTS GmbH
>> Schwieberdingen/Germany
>> ru@swb.siemens.de
>>
>>
>
>
>
next parent reply other threads:[~2002-11-29 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200211131719.gADHJYu14688@haiti.swb.siemens.de>
2002-11-28 20:15 ` Andrew Cagney [this message]
2002-12-04 4:42 Ruppert
2002-12-04 8:56 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2002-10-29 7:45 Ruppert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DE6E9BC.1000702@redhat.com \
--to=ac131313@redhat.com \
--cc=insight@sources.redhat.com \
--cc=ru@swb.siemens.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).