From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13723 invoked by alias); 4 Jan 2003 00:45:42 -0000 Mailing-List: contact insight-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sources.redhat.com Received: (qmail 13584 invoked from network); 4 Jan 2003 00:45:38 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 4 Jan 2003 00:45:38 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h040I5B12745; Fri, 3 Jan 2003 19:18:05 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h040jPn29388; Fri, 3 Jan 2003 19:45:25 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h040jPn04750; Fri, 3 Jan 2003 16:45:25 -0800 Message-ID: <3E162EA5.B754488E@redhat.com> Date: Sat, 04 Jan 2003 00:45:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gcc-patches@gcc.gnu.org, insight@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: [rfa/toplevel] Conditionalize GDB_TK References: <3E15E32C.2050405@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-q1/txt/msg00002.txt.bz2 Andrew Cagney wrote: > > Hello, > > The attatched only adds the tk directories to the gdb dependency list > when the corresponding tk files are present. That way `all-gdb' doesn't > build tk files (except when needed). Thank you! > ok? > Andrew > > PS: Disclaimer, I cut/paste the configure changes. Perhaphs someone > able to regenerate configure should commit this? > > ------------------------------------------------------------------------------- > 2003-01-03 Andrew Cagney > > * configure.in (GDB_TK): Add tcl directories conditional on > gdb/gdbtk directory being present. > * configure: Regenerate. > > Index: configure > =================================================================== > RCS file: /cvs/src/src/configure,v > retrieving revision 1.40 > diff -u -r1.40 configure > --- configure 31 Dec 2002 18:00:11 -0000 1.40 > +++ configure 3 Jan 2003 17:48:45 -0000 > @@ -2334,11 +2334,23 @@ > # so we should be able to put the 'maybe's in unconditionally and > # leave out the maybe dependencies when enable_gdbtk is false. I'm not > # 100% sure that that's safe though. > + > +gdb_tk="maybe-all-tcl maybe-all-tk maybe-all-itcl maybe-all-tix maybe-all-libgui" > case "$enable_gdbtk" in > no) > GDB_TK="" ;; > + yes) > + GDB_TK="${gdb_tk}" ;; > *) > - GDB_TK="maybe-all-tcl maybe-all-tk maybe-all-itcl maybe-all-tix maybe-all-libgui" ;; > + # Only add the dependency on gdbtk when GDBtk is part of the gdb > + # distro. Eventually someone will fix this and move Insight, nee > + # gdbtk to a separate directory. > + if test -d ${srcdir}/gdb/gdbtk ; then > + GDB_TK="${gdb_tk}" > + else > + GDB_TK="" > + fi > + ;; > esac > > # Create the 'maybe dependencies'. This uses a temporary file. > Index: configure.in > =================================================================== > RCS file: /cvs/src/src/configure.in,v > retrieving revision 1.137 > diff -u -r1.137 configure.in > --- configure.in 31 Dec 2002 18:00:11 -0000 1.137 > +++ configure.in 3 Jan 2003 17:48:45 -0000 > @@ -1677,11 +1677,23 @@ > # so we should be able to put the 'maybe's in unconditionally and > # leave out the maybe dependencies when enable_gdbtk is false. I'm not > # 100% sure that that's safe though. > + > +gdb_tk="maybe-all-tcl maybe-all-tk maybe-all-itcl maybe-all-tix maybe-all-libgui" > case "$enable_gdbtk" in > no) > GDB_TK="" ;; > + yes) > + GDB_TK="${gdb_tk}" ;; > *) > - GDB_TK="maybe-all-tcl maybe-all-tk maybe-all-itcl maybe-all-tix maybe-all-libgui" ;; > + # Only add the dependency on gdbtk when GDBtk is part of the gdb > + # distro. Eventually someone will fix this and move Insight, nee > + # gdbtk to a separate directory. > + if test -d ${srcdir}/gdb/gdbtk ; then > + GDB_TK="${gdb_tk}" > + else > + GDB_TK="" > + fi > + ;; > esac > > # Create the 'maybe dependencies'. This uses a temporary file.