From: Syd Polk <spolk@redhat.com>
To: Keith Seitz <keiths@cygnus.com>
Cc: Phil Edwards <pedwards@disaster.jaj.com>, insight@sources.redhat.com
Subject: Re: INSTALL_DATA, ranlib, and tcl-related shared libraries
Date: Fri, 20 Apr 2001 13:37:00 -0000 [thread overview]
Message-ID: <4.2.0.58.20010420133653.00ce5150@pop.cygnus.com> (raw)
In-Reply-To: <Pine.SOL.3.91.1010420121035.2271R-100000@ryobi.cygnus.com>
At 12:14 PM 4/20/01 -0700, Keith Seitz wrote:
>On Tue, 17 Apr 2001, Syd Polk wrote:
>
> > I approve these changes. Fernando or Keith, can you check them in?
>
>Ummm... May I make one small recommendation? :-)
>
>The real reason this is failing to work is because the toplevel Makefile
>is passing RANLIB down. This fails because our toolchains are,
>historically, always built static, but someone always tries to change
>them (until he runs into a sun4 or something).
>
>Anyway, the easier fix is to just ignore what we're passed and take
>whatever configure gives us.
>
>Keith
Thanks for looking further in depth into this patch. I agree with what you
are doing here.
>Index: itcl/itcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- itcl/itcl/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
>+++ itcl/itcl/unix/Makefile.in 2001/04/20 19:09:39
>@@ -149,7 +149,7 @@ SHLIB_LD = @SHLIB_LD@
> #----------------------------------------------------------------
>
> AC_FLAGS = @TCL_DEFS@
>-RANLIB = @RANLIB@
>+ITCL_RANLIB = @RANLIB@
> TOP_DIR = @ITCL_SRC_DIR@
> GENERIC_DIR = $(TOP_DIR)/generic
> UNIX_DIR = $(TOP_DIR)/unix
>@@ -193,7 +193,7 @@ all: $(ITCL_LIB_FILE) itclsh
> @ITCL_LIB_FILE@: $(OBJS)
> rm -f $(ITCL_LIB_FILE)
> @MAKE_LIB@
>- $(RANLIB) $(ITCL_LIB_FILE)
>+ $(ITCL_RANLIB) $(ITCL_LIB_FILE)
>
> itclsh: tclAppInit.o $(ITCL_LIB_FILE) @TCL_LIB_FULL_PATH@
> $(CC) @LD_FLAGS@ tclAppInit.o @ITCL_BUILD_LIB_SPEC@ \
>@@ -213,7 +213,7 @@ install-binaries: $(ITCL_LIB_FILE) itcls
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITCL_LIB_FILE)"
> @$(INSTALL_DATA) $(ITCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITCL_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(ITCL_RANLIB) $(ITCL_LIB_FILE))
> chmod 555 $(LIB_INSTALL_DIR)/$(ITCL_LIB_FILE)
> @echo "Installing itclsh"
> $(INSTALL_PROGRAM) itclsh $(BIN_INSTALL_DIR)/itclsh$(VERSION)
>Index: itcl/itk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/itcl/itk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- itcl/itk/unix/Makefile.in 2000/02/07 00:19:46 1.1.1.1
>+++ itcl/itk/unix/Makefile.in 2001/04/20 19:09:55
>@@ -193,7 +193,7 @@ SHLIB_LD = @SHLIB_LD@
> #----------------------------------------------------------------
>
> AC_FLAGS = @TCL_DEFS@
>-RANLIB = @RANLIB@
>+ITK_RANLIB = @RANLIB@
> TOP_DIR = @ITK_SRC_DIR@
> GENERIC_DIR = $(TOP_DIR)/generic
> UNIX_DIR = $(TOP_DIR)/unix
>@@ -226,7 +226,7 @@ all: itkwish
> @ITK_LIB_FILE@: ${OBJS}
> rm -f $(ITK_LIB_FILE)
> @MAKE_LIB@
>- $(RANLIB) $(ITK_LIB_FILE)
>+ $(ITK_RANLIB) $(ITK_LIB_FILE)
>
> itkwish: tkAppInit.o $(ITK_LIB_FILE) @TCL_LIB_FULL_PATH@
> @TK_LIB_FULL_PATH@ \
> @ITCL_LIB_FULL_PATH@
>@@ -253,7 +253,7 @@ install-binaries: $(ITK_LIB_FILE) itkwis
> @$(MKINSTALLDIRS) $(LIB_INSTALL_DIR) $(BIN_INSTALL_DIR)
> @echo "Installing $(ITK_LIB_FILE)"
> @$(INSTALL_DATA) $(ITK_LIB_FILE) $(LIB_INSTALL_DIR)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(ITK_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(ITK_RANLIB) $(ITK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(ITK_LIB_FILE)
> @echo "Installing itkwish"
> $(INSTALL_PROGRAM) itkwish $(BIN_INSTALL_DIR)/itkwish$(VERSION)
>Index: tcl/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tcl/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- tcl/unix/Makefile.in 1999/11/09 01:28:44 1.1.1.1
>+++ tcl/unix/Makefile.in 2001/04/20 19:09:58
>@@ -188,7 +188,7 @@ TCL_LIB_FLAG = @TCL_LIB_FLAG@
> COMPAT_OBJS = @LIBOBJS@
>
> AC_FLAGS = @DEFS@
>-RANLIB = @RANLIB@
>+TCL_RANLIB = @RANLIB@
> SRC_DIR = @srcdir@
> TOP_DIR = @srcdir@/..
> GENERIC_DIR = $(TOP_DIR)/generic
>@@ -341,7 +341,7 @@ ${TCL_SHARED_LIB_FILE}: ${OBJS}
> ${TCL_UNSHARED_LIB_FILE}: ${OBJS}
> rm -f ${TCL_LIB_FILE}
> @MAKE_LIB@
>- $(RANLIB) ${TCL_LIB_FILE}
>+ $(TCL-RANLIB) ${TCL_LIB_FILE}
>
> # END CYGNUS LOCAL
>
>@@ -449,7 +449,7 @@ install-binaries: $(TCL_LIB_FILE) tclsh
> done;
> @echo "Installing $(TCL_LIB_FILE)"
> @$(INSTALL_DATA) $(TCL_LIB_FILE) $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TCL_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(TCL_RANLIB) $(TCL_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TCL_LIB_FILE)
> @echo "Installing tclsh"
> @$(INSTALL_PROGRAM) tclsh $(BIN_INSTALL_DIR)/tclsh
>Index: tk/unix/Makefile.in
>===================================================================
>RCS file: /cvs/src/src/tk/unix/Makefile.in,v
>retrieving revision 1.1.1.1
>diff -p -u -r1.1.1.1 Makefile.in
>--- tk/unix/Makefile.in 2000/02/07 00:19:30 1.1.1.1
>+++ tk/unix/Makefile.in 2001/04/20 19:10:02
>@@ -188,7 +188,7 @@ TK_LD_SEARCH_FLAGS = @TK_LD_SEARCH_FLAGS
> #----------------------------------------------------------------
>
> AC_FLAGS = @DEFS@
>-RANLIB = @RANLIB@
>+TK_RANLIB = @RANLIB@
> SRC_DIR = @srcdir@/..
> TOP_DIR = @srcdir@/..
> GENERIC_DIR = $(TOP_DIR)/generic
>@@ -316,7 +316,7 @@ ${TK_SHARED_LIB_FILE}: ${OBJS}
> ${TK_UNSHARED_LIB_FILE}: ${OBJS}
> rm -f @TK_LIB_FILE@
> @MAKE_LIB@
>- $(RANLIB) ${TK_LIB_FILE}
>+ $(TK_RANLIB) ${TK_LIB_FILE}
>
> # END CYGNUS LOCAL
>
>@@ -386,7 +386,7 @@ install-binaries: $(TK_LIB_FILE) wish
> done;
> @echo "Installing $(TK_LIB_FILE)"
> @$(INSTALL_DATA) $(TK_LIB_FILE) $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
>- @(cd $(LIB_INSTALL_DIR); $(RANLIB) $(TK_LIB_FILE))
>+ @(cd $(LIB_INSTALL_DIR); $(TK_RANLIB) $(TK_LIB_FILE))
> @chmod 555 $(LIB_INSTALL_DIR)/$(TK_LIB_FILE)
> @echo "Installing wish"
> @$(INSTALL_PROGRAM) wish $(BIN_INSTALL_DIR)/wish
Syd Polk spolk@redhat.com
Engineering Manager +1 408 543 9430
Red Hat, Inc.
next prev parent reply other threads:[~2001-04-20 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-17 15:02 Phil Edwards
2001-04-17 16:02 ` Syd Polk
2001-04-20 12:14 ` Keith Seitz
2001-04-20 12:20 ` Mo DeJong
2001-04-20 12:23 ` Keith Seitz
2001-04-20 13:37 ` Syd Polk [this message]
2001-04-22 3:52 ` Phil Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4.2.0.58.20010420133653.00ce5150@pop.cygnus.com \
--to=spolk@redhat.com \
--cc=insight@sources.redhat.com \
--cc=keiths@cygnus.com \
--cc=pedwards@disaster.jaj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).