public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Pierre Muller <muller@ics.u-strasbg.fr>
To: Andrew Cagney <ac131313@redhat.com>, Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sources.redhat.com, insight@sources.redhat.com
Subject: Problem about  insight rename patch
Date: Thu, 03 Oct 2002 00:59:00 -0000	[thread overview]
Message-ID: <4.2.0.58.20021003094541.00abd030@ics.u-strasbg.fr> (raw)
In-Reply-To: <3D95C7C8.70407@redhat.com>

At 17:16 28/09/2002 , Andrew Cagney a écrit:
>Ok, I've pulled the attached into the 5.3 branch.
>
>Sun's not yet over the yard arm so you'll have to wait a little before cracking that coldie.

This patch has a possible problem
regarding the generated init.c code:

Until now init.c contained
references to objects that are in
libgdb.a plus cli*.o or mi*.o
files.

   But that patch also add 
_initialize_gdbtk
function reference.

I consider this as a bug because
libgdb.a suddenly depends on gtk files
which was not the case until now.

Moreover this means that gtk is still 
included in the compilation of gdb executable,
which seem to be the absolute contrary of the aim
of separating gdb and insight, no?

Basically removing 
_initialize_gdbtk from init.c
does not prevent gdb from compiling,
so the only reason why I didn't send a patch proposal
is that I don't know the correct way of fixing it?
Maybe separate init.c
into init.c and insight-init.c?
But there might be better solutions?



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

  reply	other threads:[~2002-10-03  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.44.0209270750050.1515-100000@valrhona.uglyboxes.com>
2002-09-28  8:16 ` 5.3 branch? Was: " Andrew Cagney
2002-10-03  0:59   ` Pierre Muller [this message]
2002-10-03  8:54     ` Problem about " Keith Seitz
2002-10-21 12:08       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4.2.0.58.20021003094541.00abd030@ics.u-strasbg.fr \
    --to=muller@ics.u-strasbg.fr \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=insight@sources.redhat.com \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).