public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: insight@sourceware.org
Subject: Re: Patch ping
Date: Tue, 24 Jan 2006 01:35:00 -0000	[thread overview]
Message-ID: <43D58479.9030008@redhat.com> (raw)
In-Reply-To: <43D518C6.2090309@st.com>

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

Andrew STUBBS wrote:

> I posted three trivial patches to this list nearly two weeks ago and 
> have received no response at all.

My bad, sorry.

I've checked in all your changes, but I made a slight clean-up to the 
memprefs.itb patch. I've attached the diff between your patch and mine 
(committed).

Thanks!
Keith

ChangeLog
2006-01-23  Keith Seitz  <keiths@redhat.com>

         From Andrew Stubbs  <andrew.stubbs@st.com>:
         * library/help/source.html: Add entries for the missing menu 
commands.

2006-01-23  Keith Seitz  <keiths@redhat.com>

         From Andrew Stubbs  <andrew.stubbs@st.com>:
         * library/mempref.itb (MemPref::constructor): Allow the Byte 
Per Row
         combo box to accept arbitrary values.
         (MemPref::set_bytes_per_row): Validate the new value; reject 
invalid
         entries and round up to a multiple of the word size.
         (MemPref::apply): Read the value from the text box even if the user
         has not pressed return.
         (MemPref::enable_format): Ensure the bytes per row value is 
still valid.
         (MemPref::disable_format): Likewise.
         * library/mempref.ith (MemPref): Add $gbprlist.
         * library/help/memory.html: Update.

2006-01-23  Keith Seitz  <keiths@redhat.com>

         From Andrew Stubbs  <andrew.stubbs@st.com>:
         * library/helpviewer.tcl (open_help): Add firefox and opera to the
         browser list used to display help.

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1356 bytes --]

*** yours	2006-01-23 17:10:24.000000000 -0800
--- mine	2006-01-23 17:13:53.000000000 -0800
*** 43,64 ****
  +    if {[expr {$gbpr > 150}]} {set gbpr 150}
  +
  +    # Insert the value into the combo box list, if it isn't there already.
! +    set found 0
! +    foreach item $gbprlist {
! +      if {$item == $gbpr} {
! +        set found 1
! +      }
! +    }
! +    if {[expr {$found == 0}]} {
  +      lappend gbprlist $gbpr
  +      $Widgets(b-bytes_per_row) list insert end $gbpr
  +    }
  +
  +    set s $gsize
! +    if {[expr {$s == 3}]} {set s 4}
! +    if {[expr {$s == 5}]} {set s 8}
  +    set rem [expr {$gbpr % $s}]
! +    if {[expr {$rem != 0}]} {
  +      # The bytes-per-row is not a multiple of the size.
  +      set gbpr [expr {$gbpr + ($s - $rem)}]
  +    }
--- 53,70 ----
  +    if {[expr {$gbpr > 150}]} {set gbpr 150}
  +
  +    # Insert the value into the combo box list, if it isn't there already.
! +    set found [lsearch $gbprlist $gbpr]
! +
! +    if {$found == -1} {
  +      lappend gbprlist $gbpr
  +      $Widgets(b-bytes_per_row) list insert end $gbpr
  +    }
  +
  +    set s $gsize
! +    if {$s == 3} {set s 4}
! +    if {$s == 5} {set s 8}
  +    set rem [expr {$gbpr % $s}]
! +    if {$rem != 0} {
  +      # The bytes-per-row is not a multiple of the size.
  +      set gbpr [expr {$gbpr + ($s - $rem)}]
  +    }

  reply	other threads:[~2006-01-24  1:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 17:58 Andrew STUBBS
2006-01-24  1:35 ` Keith Seitz [this message]
2006-01-24 11:33   ` Andrew STUBBS
  -- strict thread matches above, loose matches on Subject: below --
2012-04-16  9:16 Roland Schwingel
2002-01-05 12:59 Tom Tromey
2002-01-07  9:32 ` Keith Seitz
2002-01-08 11:33   ` Tom Tromey
2001-10-17  9:52 Tom Tromey
2001-10-17 13:25 ` Keith Seitz
2001-10-17 16:29   ` Tom Tromey
     [not found] <87snan6n7u.fsf@creche.redhat.com>
2001-10-10  9:28 ` Elena Zannoni
2001-10-10 10:01   ` Keith Seitz
2001-12-07 10:00     ` Keith Seitz
2001-10-11 10:35   ` Tom Tromey
2001-12-08 19:57     ` Tom Tromey
2001-12-07  8:14   ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43D58479.9030008@redhat.com \
    --to=keiths@redhat.com \
    --cc=andrew.stubbs@st.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).