From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22912 invoked by alias); 24 Jan 2006 01:35:59 -0000 Received: (qmail 22904 invoked by uid 22791); 24 Jan 2006 01:35:58 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jan 2006 01:35:57 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k0O1Ztns002713; Mon, 23 Jan 2006 20:35:55 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k0O1Zt105298; Mon, 23 Jan 2006 20:35:55 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id k0O1Zr1x026048; Mon, 23 Jan 2006 20:35:54 -0500 Message-ID: <43D58479.9030008@redhat.com> Date: Tue, 24 Jan 2006 01:35:00 -0000 From: Keith Seitz User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) MIME-Version: 1.0 To: Andrew STUBBS CC: insight@sourceware.org Subject: Re: Patch ping References: <43D518C6.2090309@st.com> In-Reply-To: <43D518C6.2090309@st.com> Content-Type: multipart/mixed; boundary="------------060701080509010701090403" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00033.txt.bz2 This is a multi-part message in MIME format. --------------060701080509010701090403 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1437 Andrew STUBBS wrote: > I posted three trivial patches to this list nearly two weeks ago and > have received no response at all. My bad, sorry. I've checked in all your changes, but I made a slight clean-up to the memprefs.itb patch. I've attached the diff between your patch and mine (committed). Thanks! Keith ChangeLog 2006-01-23 Keith Seitz From Andrew Stubbs : * library/help/source.html: Add entries for the missing menu commands. 2006-01-23 Keith Seitz From Andrew Stubbs : * library/mempref.itb (MemPref::constructor): Allow the Byte Per Row combo box to accept arbitrary values. (MemPref::set_bytes_per_row): Validate the new value; reject invalid entries and round up to a multiple of the word size. (MemPref::apply): Read the value from the text box even if the user has not pressed return. (MemPref::enable_format): Ensure the bytes per row value is still valid. (MemPref::disable_format): Likewise. * library/mempref.ith (MemPref): Add $gbprlist. * library/help/memory.html: Update. 2006-01-23 Keith Seitz From Andrew Stubbs : * library/helpviewer.tcl (open_help): Add firefox and opera to the browser list used to display help. --------------060701080509010701090403 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1356 *** yours 2006-01-23 17:10:24.000000000 -0800 --- mine 2006-01-23 17:13:53.000000000 -0800 *** 43,64 **** + if {[expr {$gbpr > 150}]} {set gbpr 150} + + # Insert the value into the combo box list, if it isn't there already. ! + set found 0 ! + foreach item $gbprlist { ! + if {$item == $gbpr} { ! + set found 1 ! + } ! + } ! + if {[expr {$found == 0}]} { + lappend gbprlist $gbpr + $Widgets(b-bytes_per_row) list insert end $gbpr + } + + set s $gsize ! + if {[expr {$s == 3}]} {set s 4} ! + if {[expr {$s == 5}]} {set s 8} + set rem [expr {$gbpr % $s}] ! + if {[expr {$rem != 0}]} { + # The bytes-per-row is not a multiple of the size. + set gbpr [expr {$gbpr + ($s - $rem)}] + } --- 53,70 ---- + if {[expr {$gbpr > 150}]} {set gbpr 150} + + # Insert the value into the combo box list, if it isn't there already. ! + set found [lsearch $gbprlist $gbpr] ! + ! + if {$found == -1} { + lappend gbprlist $gbpr + $Widgets(b-bytes_per_row) list insert end $gbpr + } + + set s $gsize ! + if {$s == 3} {set s 4} ! + if {$s == 5} {set s 8} + set rem [expr {$gbpr % $s}] ! + if {$rem != 0} { + # The bytes-per-row is not a multiple of the size. + set gbpr [expr {$gbpr + ($s - $rem)}] + } --------------060701080509010701090403--