public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: insight@sourceware.org
Subject: Re: [PATCH] Add new browsers for help
Date: Wed, 17 May 2006 18:05:00 -0000	[thread overview]
Message-ID: <446B65CF.7040805@redhat.com> (raw)
In-Reply-To: <43BEB7A4.9070901@st.com>

Hi,

Just running through my inbox...

I don't know if I ever mentioned it, but I did actually commit this 
patch in January.

Thanks again for the patch.

Keith

Andrew STUBBS wrote:
> Hi,
> 
> The attached patch adds Firefox and Opera to the list of browsers 
> Insight may use to display help.
> 
> I have added them before Mozilla on the grounds that, if installed, they 
> are usually used in preference. Obviously there will be somebody who 
> doesn't, but this seems the most likely choice to me.
> 
> Andrew Stubbs
> 
> 
> ------------------------------------------------------------------------
> 
> 2006-01-06  Andrew Stubbs  <andrew.stubbs@st.com>
> 
> 	* library/helpviewer.tcl (open_help): Add firefox and opera to the
> 	browser list used to display help.
> 
> Index: src/gdb/gdbtk/library/helpviewer.tcl
> ===================================================================
> --- src.orig/gdb/gdbtk/library/helpviewer.tcl	2006-01-03 18:23:57.000000000 +0000
> +++ src/gdb/gdbtk/library/helpviewer.tcl	2006-01-06 18:22:40.000000000 +0000
> @@ -36,13 +36,13 @@ proc open_help {hfile} {
>    # set list of viewer apps to try
>    switch [pref get gdb/compat] {
>      "KDE" {
> -      set apps {htmlview khelpcenter mozilla}
> +      set apps {htmlview khelpcenter firefox opera mozilla}
>      }
>      "GNOME" {
> -      set apps {htmlview mozilla gnome-help khelpcenter}
> +      set apps {htmlview firefox opera mozilla gnome-help khelpcenter}
>      }      
>      default {
> -      set apps {htmlview mozilla gnome-help khelpcenter netscape}
> +      set apps {htmlview firefox opera mozilla gnome-help khelpcenter netscape}
>      }
>    }
>  

      reply	other threads:[~2006-05-17 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06 18:34 Andrew STUBBS
2006-05-17 18:05 ` Keith Seitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446B65CF.7040805@redhat.com \
    --to=keiths@redhat.com \
    --cc=andrew.stubbs@st.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).