Hi,

I've finally got around to tidying up the patches I use to build Insight 
under MinGW which I'd like to submit for your approval. I do have an FSF 
assignment on file for gdb, do I need another one for Insight?

should the patches to sim/ppc/table.c, gdb/Makefile.in, gdb/configure.ac 
& gdb/configure be submitted to gdb instead?

The timer for the GUI in gdbtk.c should probably be replaced with some 
windows equivalent but ifdefing the code suffices for getting Insight 
built and running.

When Insight is started under windows it starts up with a console 
window, building insight with -mwindows removes this and looks a bit 
neater. This is the purpose of the INSIGHT_LDFLAGS I've added to replace 
WIN32LDAPP on the insight link commands. I'm not sure if this is the 
right thing to do, the cygwin build sets the latter to 
"-Wl,--subsystem,console".

The patch to tcl/win/tclWin32Dll.c is basically the one supplied by 
Andrew Stubbs in this message to the list - 
http://sourceware.org/ml/insight/2005-q3/msg00054.html . I should 
probably also mention that I need to set the executable for windows 2000 
compatibility to get it to start on my Windows XP Pro box, not yet 
tested with Vista.

Here's the complete changelog for the attached patchset generated 
against CVS HEAD this morning. I'm not quite sure of the correct format 
for this, any feedback gratefully received.

2008-02-07  Dave Murphy  <davem@devkitpro.org>

*gdb/Makefile.in
New variable INSIGHT_LDFLAGS, replaces WIN32LDAPP for linking insight

*gdb/configure.ac
New variable INSIGHT_LDFLAGS set to -mwindows under mingw
set tcl configdir to win under mingw32

*gdb/configure
regenerate

*gdb/gdbtk/generic/gdbtk-cmds.c
*gdb/gdbtk/generic/gdbtk-hooks.c
guard <sys/ioctl.h> with HAVE_SYS_IOCTL_H

*gdb/gdbtk/generic/gdbtk-interp.c
include <windows.h> under mingw32

*gdb/gdbtk/generic/gdbtk.c
guard <sys/ioctl.h> with HAVE_SYS_IOCTL_H
(gdbtk_start_timer, gdbtk_stop_timer) remove timer calls under mingw
(gdbtk_init) include windows specific commands under mingw without 
cygwin path commands

*gdb/gdbtk/library/download.itb
*gdb/gdbtk/library/interface.tcl
*gdb/gdbtk/library/prefs.tcl
*gdb/gdbtk/library/session.tcl
*gdb/gdbtk/library/srctextwin.itb
check ide_cygwin_path exists before using on windows

*gdb/gdbtk/library/targetselection.itb
(TargetSelection::default_port) default to /dev/com1 under cygwin, COM1 
under mingw
(TargetSelection::port_list) use /dev/com under cygwin, COM under mingw

*sim/ppc/table.c
(table_push) correct file read under mingw as well as cygwin

*tcl/win/tclWin32Dll.c
(DllMain, TclpCheckStackSpace) backport EXCEPTION_REGISTRATION code from 
TCL mainline

I've tested the resulting Insight builds for powerpc-eabi and arm-eabi 
targets, working well so far.

Dave