Re: MinGW patches for Insight

[Keith Seitz <keiths@redhat.com>]

Dave Murphy wrote:

> Thanks for the advice Mike, much appreciated.

Yes, ditto, Mike, for taking a peek at this for me, too. It helps to 
have extra eyeballs on this.

> Updated patch with suggested changes attached. I've submitted the ppc 
> sim patch to the gdb patches list instead.

I noticed that you're having to distinguish between windows and mingw in 
a lot of places... I think I'm going to have to whack the use of 
"tcl_platform(platform)" in favor of a procedure that returns "cygwin", 
"mingw", or "unix". If I check something in quickly, would you be 
adverse to updating your patch? Or I could wait until after this is all 
committed.

I don't see any problems with your changes to the insight code base. 
Your changes there (although numerous) are small/trivial enough that I'm 
going to forgo asking you to jump through the hoops of getting an 
assignment for Red Hat.

I'll also approve the changes to tcl/, but I'll have to take your word 
for it, since I don't have any way to test this. Hopefully a more 
cygwin-savvy developer out there will chime in with any comments.

I'm curious: have any of these Tcl mingw patches made their way 
upstream? Do they even care any more?

In any case, if your re-write your ChangeLog entries as Mike suggests, 
I'll see about applying your patches and getting them committed.

Thanks!
Keith