From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25390 invoked by alias); 9 Feb 2008 00:03:32 -0000 Received: (qmail 25381 invoked by uid 22791); 9 Feb 2008 00:03:32 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 09 Feb 2008 00:03:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m19032OM019482; Fri, 8 Feb 2008 19:03:02 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m19031b8016410; Fri, 8 Feb 2008 19:03:02 -0500 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m19030fH008408; Fri, 8 Feb 2008 19:03:01 -0500 Message-ID: <47ACEDA5.4060107@redhat.com> Date: Sat, 09 Feb 2008 00:03:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Dave Murphy CC: Mike Frysinger , insight@sourceware.org Subject: Re: MinGW patches for Insight References: <47AAC222.2080906@devkitpro.org> <47AC8FC4.8070204@devkitpro.org> <200802081304.01150.vapier@gentoo.org> <47ACE302.9030404@devkitpro.org> In-Reply-To: <47ACE302.9030404@devkitpro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00018.txt.bz2 Dave Murphy wrote: > Thanks for the advice Mike, much appreciated. Yes, ditto, Mike, for taking a peek at this for me, too. It helps to have extra eyeballs on this. > Updated patch with suggested changes attached. I've submitted the ppc > sim patch to the gdb patches list instead. I noticed that you're having to distinguish between windows and mingw in a lot of places... I think I'm going to have to whack the use of "tcl_platform(platform)" in favor of a procedure that returns "cygwin", "mingw", or "unix". If I check something in quickly, would you be adverse to updating your patch? Or I could wait until after this is all committed. I don't see any problems with your changes to the insight code base. Your changes there (although numerous) are small/trivial enough that I'm going to forgo asking you to jump through the hoops of getting an assignment for Red Hat. I'll also approve the changes to tcl/, but I'll have to take your word for it, since I don't have any way to test this. Hopefully a more cygwin-savvy developer out there will chime in with any comments. I'm curious: have any of these Tcl mingw patches made their way upstream? Do they even care any more? In any case, if your re-write your ChangeLog entries as Mike suggests, I'll see about applying your patches and getting them committed. Thanks! Keith