public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: gds <gds@chartertn.net>
Cc: insight@sources.redhat.com
Subject: Re: Crashes when "balloons" enabled
Date: Wed, 02 Apr 2008 17:23:00 -0000	[thread overview]
Message-ID: <47F3C040.7030802@redhat.com> (raw)
In-Reply-To: <ft0a21$ak5$1@ger.gmane.org>

gds wrote:

> They told me Insight has problems (paraphrasing!)

I find that very amusing. I'm actually glad that they stop recommending 
people use insight: I'm tired of being their support forum.


> diff -c -r1.1 ./insight-6.5/gdb/gdbtk/generic/gdbtk-varobj.c
> *** ./insight-6.5/gdb/gdbtk/generic/gdbtk-varobj.c      2007/07/14 
> 18:33:59     1.1
> --- ./insight-6.5/gdb/gdbtk/generic/gdbtk-varobj.c      2007/07/14 18:34:03
> ***************
> *** 599,606 ****
>   static void
>   install_variable (Tcl_Interp *interp, char *name)
>   {
> !   Tcl_CreateObjCommand (interp, name, variable_obj_command,
> !                       NULL, NULL);
>   }
> --- 599,606 ----
>   static void
>   install_variable (Tcl_Interp *interp, char *name)
>   {
> !   Tcl_CreateObjCommand (interp, name, gdbtk_call_wrapper,
> !                       (ClientData) variable_obj_command, NULL);
>   }
> 

This patch should not be necessary: varobj should NEVER longjmp. It was 
designed that way.

BTW, all those other patches are against GDB, not insight. I'm afraid I 
still don't understand what your procedure for producing this bug is. 
Can you restate it, AND BE CONCISE. (ie., 1. Load this, 2. click this, 
3. click that). The more detail you give me, the better off I'll be when 
I attempt to reproduce this here.

My guess is you've tickled a bug in GDB's varobj system. But it could be 
an unknown bug with insight (like not erasing varobjs when needed).

Keith

  parent reply	other threads:[~2008-04-02 17:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01 17:55 gds
2008-04-01 18:00 ` Keith Seitz
2008-04-01 18:48   ` gds
2008-04-02  0:02     ` Doug Graham
2008-04-02 14:00       ` gds
2008-04-02 15:52       ` gds
2008-04-02 17:14         ` Doug Graham
2008-04-02 17:23         ` Keith Seitz [this message]
2008-04-02 17:44           ` Doug Graham
2008-04-02 18:01             ` Keith Seitz
2008-04-02 20:06               ` Doug Graham
2008-04-02 20:12                 ` Keith Seitz
2008-04-02 18:19           ` gds
2008-04-02 18:41             ` Keith Seitz
2008-06-29 17:56               ` Gene Smith
2008-04-01 22:12   ` gds
2008-04-01 22:32     ` gds
2008-04-02 17:16   ` gds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F3C040.7030802@redhat.com \
    --to=keiths@redhat.com \
    --cc=gds@chartertn.net \
    --cc=insight@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).