public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: insight <insight@sourceware.org>
Subject: [PATCH] Fix find_and_open_source link error
Date: Mon, 21 Apr 2008 20:16:00 -0000	[thread overview]
Message-ID: <480CF4BA.4030007@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

Hi,

A recent change in gdb has rendered a function invisible to insight, so 
I've found a suitable replacement and committed the attached patch.

Keith

ChangeLog
2008-04-21  Keith Seitz  <keiths@redhat.com>

         * generic/gdbtk-cmds.c (symtab_to_filename): Call gdb's
         open_source_file instead of find_and_open_source.

[-- Attachment #2: find_and_open_source.patch --]
[-- Type: text/x-patch, Size: 1306 bytes --]

Index: generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.98
diff -u -p -r1.98 gdbtk-cmds.c
--- generic/gdbtk-cmds.c	3 Mar 2008 23:25:03 -0000	1.98
+++ generic/gdbtk-cmds.c	21 Apr 2008 20:14:30 -0000
@@ -1,5 +1,5 @@
 /* Tcl/Tk command definitions for Insight.
-   Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007
+   Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007, 2008
    Free Software Foundation, Inc.
 
    Written by Stu Grossman <grossman@cygnus.com> of Cygnus Support.
@@ -3004,13 +3004,9 @@ gdb_CA_to_TAS (ClientData clientData, Tc
  * with something similar, but different enough to break
  * Insight.
  */
-int find_and_open_source (struct objfile *objfile, const char *filename,
-			  const char *dirname, char **fullname);
-
 char *
 symtab_to_filename (struct symtab *s)
 {
-
   int r;
 
   if (!s)
@@ -3018,8 +3014,7 @@ symtab_to_filename (struct symtab *s)
 
   /* Don't check s->fullname here, the file could have been 
      deleted/moved/..., look for it again */
-  r = find_and_open_source (s->objfile, s->filename, s->dirname,
-			    &s->fullname);
+  r = open_source_file (s);
   if (r)
     close (r);
 

                 reply	other threads:[~2008-04-21 20:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480CF4BA.4030007@redhat.com \
    --to=keiths@redhat.com \
    --cc=insight@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).