From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22977 invoked by alias); 21 Apr 2008 20:16:33 -0000 Received: (qmail 22969 invoked by uid 22791); 21 Apr 2008 20:16:33 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 Apr 2008 20:16:09 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3LKG7o4032703 for ; Mon, 21 Apr 2008 16:16:07 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3LKG7iW003732 for ; Mon, 21 Apr 2008 16:16:07 -0400 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3LKG5Fu008315 for ; Mon, 21 Apr 2008 16:16:06 -0400 Message-ID: <480CF4BA.4030007@redhat.com> Date: Mon, 21 Apr 2008 20:16:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: insight Subject: [PATCH] Fix find_and_open_source link error Content-Type: multipart/mixed; boundary="------------030308090907050804050804" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00037.txt.bz2 This is a multi-part message in MIME format. --------------030308090907050804050804 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 334 Hi, A recent change in gdb has rendered a function invisible to insight, so I've found a suitable replacement and committed the attached patch. Keith ChangeLog 2008-04-21 Keith Seitz * generic/gdbtk-cmds.c (symtab_to_filename): Call gdb's open_source_file instead of find_and_open_source. --------------030308090907050804050804 Content-Type: text/x-patch; name="find_and_open_source.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="find_and_open_source.patch" Content-length: 1306 Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.98 diff -u -p -r1.98 gdbtk-cmds.c --- generic/gdbtk-cmds.c 3 Mar 2008 23:25:03 -0000 1.98 +++ generic/gdbtk-cmds.c 21 Apr 2008 20:14:30 -0000 @@ -1,5 +1,5 @@ /* Tcl/Tk command definitions for Insight. - Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007 + Copyright (C) 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2007, 2008 Free Software Foundation, Inc. Written by Stu Grossman of Cygnus Support. @@ -3004,13 +3004,9 @@ gdb_CA_to_TAS (ClientData clientData, Tc * with something similar, but different enough to break * Insight. */ -int find_and_open_source (struct objfile *objfile, const char *filename, - const char *dirname, char **fullname); - char * symtab_to_filename (struct symtab *s) { - int r; if (!s) @@ -3018,8 +3014,7 @@ symtab_to_filename (struct symtab *s) /* Don't check s->fullname here, the file could have been deleted/moved/..., look for it again */ - r = find_and_open_source (s->objfile, s->filename, s->dirname, - &s->fullname); + r = open_source_file (s); if (r) close (r); --------------030308090907050804050804--