From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-6337-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 4086 invoked by alias); 23 Apr 2008 18:10:10 -0000
Received: (qmail 4077 invoked by uid 22791); 23 Apr 2008 18:10:09 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 23 Apr 2008 18:09:52 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3NI9mh5030659; 	Wed, 23 Apr 2008 14:09:48 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3NI9lNR005255; 	Wed, 23 Apr 2008 14:09:47 -0400
Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3NI9jrf029426; 	Wed, 23 Apr 2008 14:09:46 -0400
Message-ID: <480F7A05.4050005@redhat.com>
Date: Wed, 23 Apr 2008 18:10:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20070728)
MIME-Version: 1.0
To: Masaki Muranaka <monaka@monami-software.com>
CC: insight <insight@sourceware.org>
Subject: Re: [tcl] Undefined NULL in tcl/compat/strstr.c
References: <EE8EE936-F2AD-41D0-9C29-5DB98D3AE80C@monami-software.com>
In-Reply-To: <EE8EE936-F2AD-41D0-9C29-5DB98D3AE80C@monami-software.com>
Content-Type: multipart/mixed;  boundary="------------050502040904040601000808"
X-IsSubscribed: yes
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
X-SW-Source: 2008-q2/txt/msg00042.txt.bz2

This is a multi-part message in MIME format.
--------------050502040904040601000808
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-length: 630

[Moving to correct list]

Masaki Muranaka wrote:
> Hello,
> 
> This is obvious. Could anyone commit my patch?
> 
> 
> 2008-04-24  Masaki Muranaka  <monaka@monami-software.com>
> 
>         * compat/strstr.c : Add include stddef.h to get NULL define.

Having seen this patch, I took a peek at what the upstream Tcl group has 
done. They've taken a slightly different tack, which I have committed:

tcl/ChangeLog
2008-04-23  Keith Seitz  <keiths@redhat.com>

         Based on patch from Masaki Muranaka  <monaka@monami-software.com>:
         * compat/strstr.c: Include tcl.h and define NULL if it is
         not already defined.

--------------050502040904040601000808
Content-Type: text/x-patch;
 name="tcl-strstr-NULL.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="tcl-strstr-NULL.patch"
Content-length: 526

Index: tcl/compat/strstr.c
===================================================================
RCS file: /cvs/src/src/tcl/compat/strstr.c,v
retrieving revision 1.5
diff -u -p -r1.5 strstr.c
--- tcl/compat/strstr.c	21 Jan 2003 19:39:57 -0000	1.5
+++ tcl/compat/strstr.c	23 Apr 2008 18:07:50 -0000
@@ -12,6 +12,11 @@
  * RCS: @(#) $Id: strstr.c,v 1.3 2002/01/26 01:10:08 dgp Exp $
  */
 
+#include "tcl.h"
+#ifndef NULL
+#define NULL 0
+#endif
+
 /*
  *----------------------------------------------------------------------
  *

--------------050502040904040601000808--