public inbox for insight@sourceware.org
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: insight@sourceware.org
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: [ob]: Get rid of deprecated_print_address_numeric
Date: Mon, 19 May 2008 09:06:00 -0000	[thread overview]
Message-ID: <483142FF.5060304@de.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi,

this patch: http://sourceware.org/ml/gdb-patches/2008-05/msg00540.html

gets rid of deprecated_print_address_numeric in GDB. Therefor I propose following
patch for Insight as obvious. This patch is untested. I'll be very happy if someone
with Insight experience could look it over and give it a test.

Thank you very much. Ok to commit as obvious? 

ChangeLog:

	* generic/gdbtk-cmds.c (gdbtk_load_asm): Replace
	deprecated_print_address_numeric with paddress.
	* generic/gdbtk-stack.c (get_frame_name): Likewise (comment).


Regards,
Markus

-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


[-- Attachment #2: diff-gdbtk --]
[-- Type: text/plain, Size: 1198 bytes --]

diff -urpN src/gdb/gdbtk/generic/gdbtk-cmds.c dev/gdb/gdbtk/generic/gdbtk-cmds.c
--- src/gdb/gdbtk/generic/gdbtk-cmds.c	2008-05-12 09:24:54.000000000 +0200
+++ dev/gdb/gdbtk/generic/gdbtk-cmds.c	2008-05-19 10:59:19.000000000 +0200
@@ -1889,7 +1889,7 @@ gdbtk_load_asm (ClientData clientData, C
   for (i = 0; i < 3; i++)
     Tcl_SetObjLength (client_data->result_obj[i], 0);
 
-  deprecated_print_address_numeric (pc, 1, gdb_stdout);
+  fputs_filtered (paddress (pc), gdb_stdout);
   gdb_flush (gdb_stdout);
 
   result_ptr->obj_ptr = client_data->result_obj[1];
diff -urpN src/gdb/gdbtk/generic/gdbtk-stack.c dev/gdb/gdbtk/generic/gdbtk-stack.c
--- src/gdb/gdbtk/generic/gdbtk-stack.c	2008-03-07 09:03:19.000000000 +0100
+++ dev/gdb/gdbtk/generic/gdbtk-stack.c	2008-05-19 11:00:44.000000000 +0200
@@ -594,7 +594,7 @@ get_frame_name (Tcl_Interp *interp, Tcl_
       /* we have no convenient way to deal with this yet... */
       if (fi->pc != sal.pc || !sal.symtab)
 	{
-	  deprecated_print_address_numeric (fi->pc, 1, gdb_stdout);
+	  fputs_filtered (paddress (fi->pc), gdb_stdout);
 	  printf_filtered (" in ");
 	}
       printf_symbol_filtered (gdb_stdout, funname ? funname : "??", funlang,

                 reply	other threads:[~2008-05-19  9:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483142FF.5060304@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=insight@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).