From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26807 invoked by alias); 28 Aug 2008 12:57:16 -0000 Received: (qmail 26793 invoked by uid 22791); 28 Aug 2008 12:57:15 -0000 X-Spam-Check-By: sourceware.org Received: from s200bog18.obsmtp.com (HELO s200bog18.obsmtp.com) (207.126.150.132) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 28 Aug 2008 12:56:30 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu2sys200bob018.postini.com ([207.126.147.11]) with SMTP; Thu, 28 Aug 2008 12:56:25 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BB2BCDA97; Thu, 28 Aug 2008 12:56:14 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7A09A4C345; Thu, 28 Aug 2008 12:56:14 +0000 (GMT) Received: from crx595.cro.st.com (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.8.7a) with ESMTP id CPP15395 (AUTH "denis pilat"); Thu, 28 Aug 2008 14:56:45 +0200 (CEST) Message-ID: <48B6A06D.6080406@st.com> Date: Fri, 12 Sep 2008 14:20:00 -0000 From: Denis PILAT User-Agent: Thunderbird 2.0.0.16 (X11/20080707) MIME-Version: 1.0 To: "Maciej W. Rozycki" , insight@sources.redhat.com Cc: Denis PILAT Subject: Re: testsuite/gdb.gdbtk References: <480D8ADB.5050609@st.com> <480F1BFF.5040305@st.com> In-Reply-To: <480F1BFF.5040305@st.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00053.txt.bz2 I forgot to ping you about this patch. -- Denis > > About patches, would somebody accept the following one that avoid > having an error when TCL_LIBRARY variable is not set ? > Thanks, > > -- > Denis > > 2008-04-23 Denis Pilat > > * insight-support.exp (gdbtk_start): test TCL_LIBRARY env. variable > before being unset. > > > Index: insight-support.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.gdbtk/insight-support.exp,v > retrieving revision 1.2 > diff -u -p -r1.2 insight-support.exp > --- insight-support.exp 8 Feb 2007 17:12:50 -0000 1.2 > +++ insight-support.exp 23 Apr 2008 11:05:58 -0000 > @@ -98,8 +98,9 @@ proc gdbtk_start {test} { > set env(SRCDIR) $abs_srcdir > set env(GDBTK_VERBOSE) 1 > set env(GDBTK_LOGFILE) [to_tcl_path [file join $objdir gdb.log]] > - unset -nocomplain env(TCL_LIBRARY) > - > + if {[info exists env(TCL_LIBRARY)]} { > + unset -nocomplain env(TCL_LIBRARY) > + } > set err [catch {exec $INSIGHT -nx -q --tclcommand=$test} res] > if { $err } { > perror "Execing $INSIGHT failed: $res" > > > > > > > Maciej W. Rozycki wrote: >> On Tue, 22 Apr 2008, Denis PILAT wrote: >> >> >>> I'm wondering why this directory is not delivered within insight >>> distribution. >>> Is there anybody who knows if this testsuite is maintained and >>> working well ? >>> >> >> It mostly worked for me for the mipsisa32-sde-elf target and the >> mips-sim-sde32 target board the last time I tried -- that's a >> configuration using the GNU simulator. There may have been two or three >> failures which I had no time to investigate unfortunately, but the >> majority of tests passed. I have no access to that configuration >> anymore, >> but I hope that sounds encouraging to you. As to maintenance, I >> would not >> call that very active, but I am sure if you find a bug and prepare a fix >> which you will post here, it will be gladly accepted. :-) >> >> Maciej >> >> >