From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24267 invoked by alias); 2 Sep 2008 17:32:52 -0000 Received: (qmail 24250 invoked by uid 22791); 2 Sep 2008 17:32:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Sep 2008 17:32:17 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m82HVOIZ030470; Tue, 2 Sep 2008 13:31:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m82HVDTl017647; Tue, 2 Sep 2008 13:31:13 -0400 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m82HVAcV016703; Tue, 2 Sep 2008 13:31:11 -0400 Message-ID: <48BD785E.6060209@redhat.com> Date: Wed, 17 Sep 2008 12:47:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Aurelien Buhrig CC: insight@sourceware.org Subject: Re: build pb References: <19267091.post@talk.nabble.com> In-Reply-To: <19267091.post@talk.nabble.com> Content-Type: multipart/mixed; boundary="------------060706030501000503050300" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q3/txt/msg00056.txt.bz2 This is a multi-part message in MIME format. --------------060706030501000503050300 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 560 Aurelien Buhrig wrote: > Since the 21th of august 2008, according to gdb changelog, > DEPRECATED_SYMBOL_NAME definition has been removed. > So insight does not compile any more... > > How to fix this ? With a patch? ;-) Keith 2008-09-02 Keith Seitz * generic/gdbtk-cmds.c (gdb_listfuncs): Use SYMBOL_PRINT_NAME instead of DEPRECATED_SYMBOL_NAME. * generic/gdbtk-stack.c (gdb_block_vars): Likewise. (gdb_get_vars_command): Likewise. * generic/gdbtk.h (GDBTK_SYMBOL_SOURCE_NAME): Likewise. --------------060706030501000503050300 Content-Type: text/x-patch; name="remove-DEPRECATED_SYMBOL_NAME.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="remove-DEPRECATED_SYMBOL_NAME.patch" Content-length: 2733 Index: generic/gdbtk.h =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk.h,v retrieving revision 1.12 diff -u -p -r1.12 gdbtk.h --- generic/gdbtk.h 14 Jul 2008 23:43:36 -0000 1.12 +++ generic/gdbtk.h 2 Sep 2008 17:28:39 -0000 @@ -176,7 +176,7 @@ extern void #define GDBTK_SYMBOL_SOURCE_NAME(symbol) \ (SYMBOL_DEMANGLED_NAME (symbol) != NULL \ ? SYMBOL_DEMANGLED_NAME (symbol) \ - : DEPRECATED_SYMBOL_NAME (symbol)) + : SYMBOL_PRINT_NAME (symbol)) /* gdbtk_add_hooks - add all the hooks to gdb. This will get called Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.102 diff -u -p -r1.102 gdbtk-cmds.c --- generic/gdbtk-cmds.c 2 Aug 2008 22:08:32 -0000 1.102 +++ generic/gdbtk-cmds.c 2 Sep 2008 17:28:40 -0000 @@ -1495,7 +1495,7 @@ gdb_listfuncs (clientData, interp, objc, } else { - funcVals[0] = Tcl_NewStringObj (DEPRECATED_SYMBOL_NAME (sym), -1); + funcVals[0] = Tcl_NewStringObj (SYMBOL_PRINT_NAME (sym), -1); funcVals[1] = not_mangled; } Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Index: generic/gdbtk-stack.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v retrieving revision 1.28 diff -u -p -r1.28 gdbtk-stack.c --- generic/gdbtk-stack.c 14 Jul 2008 23:43:36 -0000 1.28 +++ generic/gdbtk-stack.c 2 Sep 2008 17:28:40 -0000 @@ -122,7 +122,7 @@ gdb_block_vars (ClientData clientData, T case LOC_REGISTER: /* register */ case LOC_COMPUTED: /* computed location */ Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, - Tcl_NewStringObj (DEPRECATED_SYMBOL_NAME (sym), + Tcl_NewStringObj (SYMBOL_PRINT_NAME (sym), -1)); break; @@ -337,7 +337,7 @@ gdb_get_vars_command (ClientData clientD case LOC_REGPARM_ADDR: /* indirect register arg */ if (arguments) Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, - Tcl_NewStringObj (DEPRECATED_SYMBOL_NAME (sym), -1)); + Tcl_NewStringObj (SYMBOL_PRINT_NAME (sym), -1)); break; case LOC_LOCAL: /* stack local */ case LOC_STATIC: /* static */ @@ -345,7 +345,7 @@ gdb_get_vars_command (ClientData clientD case LOC_COMPUTED: /* computed location */ if (!arguments) Tcl_ListObjAppendElement (interp, result_ptr->obj_ptr, - Tcl_NewStringObj (DEPRECATED_SYMBOL_NAME (sym), -1)); + Tcl_NewStringObj (SYMBOL_PRINT_NAME (sym), -1)); break; } } --------------060706030501000503050300--