From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30205 invoked by alias); 8 Oct 2008 12:38:24 -0000 Received: (qmail 29947 invoked by uid 22791); 8 Oct 2008 12:38:23 -0000 X-Spam-Check-By: sourceware.org Received: from inbound.iw3d.co.uk (HELO yggdrasil.iwks.multi.local) (85.133.44.195) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Oct 2008 12:37:48 +0000 Received: from hafnium.iwks.multi.local ([10.79.1.126]) by yggdrasil.iwks.multi.local with esmtp (Exim 4.63) (envelope-from ) id 1KnYIT-0004AR-88 for insight@sourceware.org; Wed, 08 Oct 2008 13:37:45 +0100 Message-ID: <48ECA997.1050502@ideaworks3d.com> Date: Wed, 08 Oct 2008 12:38:00 -0000 From: Dave Poston User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: insight@sourceware.org Subject: fix for help with mingw build Content-Type: multipart/mixed; boundary="------------010609040506050909020402" X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "yggdrasil.iwks.multi.local", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Insight 6.8 built under mingw fires an 'unknown command ide_shell_execute' if you try to use help. Attached is a fix for this, registration of ide_shell_execute needs to happen under mingw as well as cygwin. [...] Content analysis details: (0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 AWL AWL: From: address is in the auto white-list X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00000.txt.bz2 This is a multi-part message in MIME format. --------------010609040506050909020402 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 509 Hi, Insight 6.8 built under mingw fires an 'unknown command ide_shell_execute' if you try to use help. Attached is a fix for this, registration of ide_shell_execute needs to happen under mingw as well as cygwin. Also the ide_shell_execute command with 'open' as its operation didn't work for me, whereas using "" (default action, equivalent to double-clicking the file) did. I'm new to this business of sending patches around, let me know if I've got anything wrong! Dave --------------010609040506050909020402 Content-Type: text/plain; name="diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff.txt" Content-length: 1199 diff -Nurb insight-6.8-orig/insight-6.8/gdb/gdbtk/generic/gdbtk.c insight-6.8/insight-6.8/gdb/gdbtk/generic/gdbtk.c --- insight-6.8-orig/insight-6.8/gdb/gdbtk/generic/gdbtk.c Mon Mar 3 23:25:04 2008 +++ insight-6.8/insight-6.8/gdb/gdbtk/generic/gdbtk.c Tue Oct 7 18:21:23 2008 @@ -537,9 +537,13 @@ /* Path conversion functions. */ if (ide_create_cygwin_path_command (gdbtk_interp) != TCL_OK) error ("cygwin path command initialization failed"); +#endif + +#ifdef __WIN32__ if (ide_create_shell_execute_command (gdbtk_interp) != TCL_OK) error ("cygwin shell execute command initialization failed"); #endif + /* Only for testing -- and only when it can't be done any other way. */ diff -Nurb insight-6.8-orig/insight-6.8/gdb/gdbtk/library/helpviewer.tcl insight-6.8/insight-6.8/gdb/gdbtk/library/helpviewer.tcl --- insight-6.8-orig/insight-6.8/gdb/gdbtk/library/helpviewer.tcl Sat Feb 9 01:23:42 2008 +++ insight-6.8/insight-6.8/gdb/gdbtk/library/helpviewer.tcl Wed Oct 8 13:05:24 2008 @@ -25,7 +25,7 @@ # windows is easy if {$::gdbtk_platform(platform) == "windows"} { - ide_shell_execute open $link + ide_shell_execute "" $link return } --------------010609040506050909020402--