From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15065 invoked by alias); 26 Oct 2008 17:15:23 -0000 Received: (qmail 15051 invoked by uid 22791); 26 Oct 2008 17:15:21 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 26 Oct 2008 17:14:31 +0000 Received: by fg-out-1718.google.com with SMTP id e12so1941645fga.0 for ; Sun, 26 Oct 2008 10:14:27 -0700 (PDT) Received: by 10.86.96.18 with SMTP id t18mr2343669fgb.56.1225041267876; Sun, 26 Oct 2008 10:14:27 -0700 (PDT) Received: from ?192.168.1.111? (ppp78-37-162-237.pppoe.avangarddsl.ru [78.37.162.237]) by mx.google.com with ESMTPS id 4sm5253505fgg.4.2008.10.26.10.14.25 (version=SSLv3 cipher=RC4-MD5); Sun, 26 Oct 2008 10:14:26 -0700 (PDT) Message-ID: <4904A54C.5060501@gmail.com> Date: Sun, 26 Oct 2008 17:15:00 -0000 From: Martin Rakhmanov User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Alon Bar-Lev CC: insight@sourceware.org Subject: Re: gdb/gdbtk/generic/gdbtk-stack.c - fail due to strict aliasing References: <200810260107.31955.alon.barlev@gmail.com> In-Reply-To: <200810260107.31955.alon.barlev@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00007.txt.bz2 This allows to compile currently available snapshot (ftp://sourceware.org/pub/insight/snapshots/current/insight-weekly-6.8.50-20081021-tar.bz2) but again does not fix problem with running insight on Fedora 9: the snapshot ships with old tcl/tk versions and uses them. Thanks Martin Alon Bar-Lev wrote: > Hello, > > Reported as binutils bug#6986 [1] > > arguments = *(int*) &clientData; > > Gets strict aliasing warning that escalate to error and fails build. > > Attached a simple temp fix against head. > > But the apparently the original has some issue too. > > Regards, > Alon Bar-Lev. > > ------- Additional Comment #2 From Andreas Schwab 2008-10-25 22:53 ------- > Neither gdb nor gdbtk are part of binutils. And the patch is as broken as the > original code, it still fails on big-endian 64-bit architectures. Please > report that to the insight mailinglist. > > [1] http://sourceware.org/bugzilla/show_bug.cgi?id=6986 > > --- > > Index: gdb/gdbtk/generic/gdbtk-stack.c > =================================================================== > RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v > retrieving revision 1.29 > diff -u -B -r1.29 gdbtk-stack.c > --- gdb/gdbtk/generic/gdbtk-stack.c 2 Sep 2008 17:29:23 -0000 1.29 > +++ gdb/gdbtk/generic/gdbtk-stack.c 25 Oct 2008 22:28:12 -0000 > @@ -285,7 +285,10 @@ > return TCL_ERROR; > } > > - arguments = *(int*) &clientData; > +{ > + void *p = &clientData; > + arguments = *(int*) p; > +} > > /* Initialize the result pointer to an empty list. */ > >