insight-weekly-6.8.50-20081103 fails to compile

insight-weekly-6.8.50-20081103 fails to compile

[Martin Rakhmanov]

Latest available snapshot fails to compile:

ftp://sourceware.org/pub/insight/snapshots/current/insight-weekly-6.8.50-20081103-tar.bz2

gcc -g -O2   -I. -I.././gdb -I.././gdb/config 
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H 
-I.././gdb/../include/opcode -I.././gdb/../readline/.. -I../bfd 
-I.././gdb/../bfd -I.././gdb/../include -I../libdecnumber 
-I.././gdb/../libdecnumber  -I.././gdb/gnulib -Ignulib  -DMI_OUT=1 
-DTUI=1  -DGDBTK  -Wall -Wdeclaration-after-statement -Wpointer-arith 
-Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wno-switch 
-Wno-char-subscripts -Werror -c -o gdbtk-cmds.o -MT gdbtk-cmds.o -MMD 
-MP -MF .deps/gdbtk-cmds.Tpo -I.././gdb/../libgui/src 
-I/home/martin/Download/src/tcl/generic 
-I/home/martin/Download/src/tk/generic 
-DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" 
-DSRC_DIR=\"/home/martin/Download/src/gdb\" 
.././gdb/gdbtk/generic/gdbtk-cmds.c
.././gdb/gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_eval’:
.././gdb/gdbtk/generic/gdbtk-cmds.c:636: error: too many arguments to 
function ‘val_print’
cc1: warnings being treated as errors
.././gdb/gdbtk/generic/gdbtk-cmds.c: In function ‘gdb_update_mem’:
.././gdb/gdbtk/generic/gdbtk-cmds.c:2534: error: passing argument 3 of 
‘print_scalar_formatted’ makes pointer from integer without a cast
make[2]: *** [gdbtk-cmds.o] Error 1
make[2]: Leaving directory `/home/martin/Download/src/gdb'
make[1]: *** [all-gdb] Error 2
make[1]: Leaving directory `/home/martin/Download/src'
make: *** [all] Error 2

I see no val_print defined which accepts 10 args. How this ever could be 
checked in?

It looks like the project is almost dead. What is the future for insight?

Martin

Re: insight-weekly-6.8.50-20081103 fails to compile

[Keith Seitz]

Martin Rakhmanov wrote:
> I see no val_print defined which accepts 10 args. How this ever could be 
> checked in?

Because that change was made to gdb, and I was off last week, so I did 
not get a chance to update insight sources yet. I have a patch for this, 
but it is not yet tested, and I need to get back to paying work.

> It looks like the project is almost dead. What is the future for insight?

IMO, there is very little future, but while I'm stuck using gdb for 
debugging, I will always keep insight limping along with the 
functionality I require (which is mostly just the source window, 
locals/watch, console, and bp window). Gdb is changing MUCH faster than 
I can keep up by myself.

As a result, I will probably put insight out to official pasture at the 
end of the year: meaning that I will officially step down as head 
maintainer, leaving that post vacant. The future of snapshots, releases, 
bug database, etc is undetermined. I will probably close/stop almost 
everything. This list will probably be one of the few things that remains.

Heck, with the work that's being done to integrate python into gdb, I 
might just start a new version of insight ((c) FSF this time) using python.

Believe it or not, I still believe we got a lot of things right.

Keith

Re: insight-weekly-6.8.50-20081103 fails to compile

[Kevin Buettner]

On Sun, 09 Nov 2008 15:47:27 +0300
Martin Rakhmanov <rakhmanov.martin@gmail.com> wrote:

> Latest available snapshot fails to compile: [...]

Below is a patch which fixes the problem that Martin reported.

Okay?

In gdbtk/ChangeLog:

	* generic/gdbtk-cmds.c (valprint.h): Include.
	(gdb_eval): Fetch print options via get_formatted_print_options.
	Update call to val_print.
	(gdb_update_mem): Likewise, but for print_scalar_formatted.
	* generic/gdbtk-register.c (valprint.h): Include.
	(get_register): Use get_formatted_print_options.  Update calls
	to val_print.
	* generic/gdbtk-wrapper.c (valprint.h): Include.
	(wrap_val_print): Use get_formatted_print_options.  Delete
	variables deref_ref and pretty; assign to equivalent fields
	in the value_print_options struct instead.  Update call to
	val_print.

Index: gdbtk/generic/gdbtk-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v
retrieving revision 1.105
diff -u -p -r1.105 gdbtk-cmds.c
--- gdbtk/generic/gdbtk-cmds.c	22 Sep 2008 18:32:41 -0000	1.105
+++ gdbtk/generic/gdbtk-cmds.c	13 Dec 2008 01:08:59 -0000
@@ -43,6 +43,7 @@
 #include "exceptions.h"
 #include "language.h"
 #include "target.h"
+#include "valprint.h"
 
 /* tcl header files includes varargs.h unless HAS_STDARG is defined,
    but gdb uses stdarg.h, so make sure HAS_STDARG is defined.  */
@@ -614,6 +615,7 @@ gdb_eval (ClientData clientData, Tcl_Int
   struct ui_file *stb;
   long dummy;
   char *result;
+  struct value_print_options opts;
 
   if (objc != 2 && objc != 3)
     {
@@ -624,6 +626,8 @@ gdb_eval (ClientData clientData, Tcl_Int
   if (objc == 3)
     format = *(Tcl_GetStringFromObj (objv[2], NULL));
 
+  get_formatted_print_options (&opts, format);
+
   expr = parse_expression (Tcl_GetStringFromObj (objv[1], NULL));
   old_chain = make_cleanup (free_current_contents, &expr);
   val = evaluate_expression (expr);
@@ -633,7 +637,7 @@ gdb_eval (ClientData clientData, Tcl_Int
   make_cleanup_ui_file_delete (stb);
   val_print (value_type (val), value_contents (val),
 	     value_embedded_offset (val), VALUE_ADDRESS (val),
-	     stb, format, 0, 0, 0, current_language);
+	     stb, 0, &opts, current_language);
   result = ui_file_xstrdup (stb, &dummy);
   Tcl_SetObjResult (interp, Tcl_NewStringObj (result, -1));
   xfree (result);
@@ -2529,9 +2533,13 @@ gdb_update_mem (ClientData clientData, T
 	}
       else
 	{
+	  struct value_print_options opts;
+
+	  get_formatted_print_options (&opts, format);
+
 	  /* print memory to our uiout file and set the table's variable */
 	  ui_file_rewind (stb);
-	  print_scalar_formatted (mptr, val_type, format, asize, stb);
+	  print_scalar_formatted (mptr, val_type, &opts, asize, stb);
 	  tmp = ui_file_xstrdup (stb, &dummy);
 
 	  /* See comments above on max_*_len */
Index: gdbtk/generic/gdbtk-register.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-register.c,v
retrieving revision 1.35
diff -u -p -r1.35 gdbtk-register.c
--- gdbtk/generic/gdbtk-register.c	12 May 2008 07:24:54 -0000	1.35
+++ gdbtk/generic/gdbtk-register.c	13 Dec 2008 01:09:00 -0000
@@ -26,6 +26,7 @@
 #include "target.h"
 #include "gdb_string.h"
 #include "language.h"
+#include "valprint.h"
 
 #include <tcl.h>
 #include "gdbtk.h"
@@ -329,16 +330,22 @@ get_register (int regnum, map_arg arg)
     }
   else
     {
+      struct value_print_options opts;
+
+      get_formatted_print_options (&opts, format);
+      opts.deref_ref = 1;
+      opts.pretty = Val_pretty_default;
+
       if ((TYPE_CODE (reg_vtype) == TYPE_CODE_UNION)
 	  && (strcmp (FIELD_NAME (TYPE_FIELD (reg_vtype, 0)), 
 		      gdbarch_register_name (current_gdbarch, regnum)) == 0))
 	{
 	  val_print (FIELD_TYPE (TYPE_FIELD (reg_vtype, 0)), buffer, 0, 0,
-		     stb, format, 1, 0, Val_pretty_default, current_language);
+		     stb, 0, &opts, current_language);
 	}
       else
 	val_print (reg_vtype, buffer, 0, 0,
-		   stb, format, 1, 0, Val_pretty_default, current_language);
+		   stb, 0, &opts, current_language);
     }
   
   res = ui_file_xstrdup (stb, &dummy);
Index: gdbtk/generic/gdbtk-wrapper.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-wrapper.c,v
retrieving revision 1.17
diff -u -p -r1.17 gdbtk-wrapper.c
--- gdbtk/generic/gdbtk-wrapper.c	14 Jul 2008 23:43:36 -0000	1.17
+++ gdbtk/generic/gdbtk-wrapper.c	13 Dec 2008 01:09:00 -0000
@@ -25,6 +25,7 @@
 #include "block.h"
 #include "exceptions.h"
 #include "language.h"
+#include "valprint.h"
 #include "gdbtk-wrapper.h"
 
 /*
@@ -204,21 +205,21 @@ wrap_val_print (char *a)
   CORE_ADDR address;
   struct ui_file *stream;
   int format;
-  int deref_ref;
   int recurse;
-  enum val_prettyprint pretty;
+  struct value_print_options opts;
 
   type = (struct type *) (*args)->args[0].ptr;
   valaddr = (gdb_byte *) (*args)->args[1].ptr;
   address = *(CORE_ADDR *) (*args)->args[2].ptr;
   stream = (struct ui_file *) (*args)->args[3].ptr;
   format = (*args)->args[4].integer;
-  deref_ref = (*args)->args[5].integer;
+  get_formatted_print_options (&opts, format);
+  opts.deref_ref = (*args)->args[5].integer;
   recurse = (*args)->args[6].integer;
-  pretty = (enum val_prettyprint) (*args)->args[7].integer;
+  opts.pretty = (enum val_prettyprint) (*args)->args[7].integer;
 
-  val_print (type, valaddr, 0, address, stream, format, deref_ref,
-	     recurse, pretty, current_language);
+  val_print (type, valaddr, 0, address, stream, recurse, &opts,
+             current_language);
   return 1;
 }
 

Re: insight-weekly-6.8.50-20081103 fails to compile

[Keith Seitz]

Kevin Buettner wrote:
> On Sun, 09 Nov 2008 15:47:27 +0300
> Martin Rakhmanov <rakhmanov.martin@gmail.com> wrote:
> 
>> Latest available snapshot fails to compile: [...]
> 
> Below is a patch which fixes the problem that Martin reported.
> 
> Okay?

Yes, thank you very much!

Keith

Re: insight-weekly-6.8.50-20081103 fails to compile

[Kevin Buettner]

On Sat, 13 Dec 2008 10:13:06 -0800
Keith Seitz <keiths@redhat.com> wrote:

> > Below is a patch which fixes the problem that Martin reported.
> > 
> > Okay?
> 
> Yes, thank you very much!

Committed.

Kevin