From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21842 invoked by alias); 24 Apr 2009 03:29:44 -0000 Received: (qmail 21830 invoked by uid 22791); 24 Apr 2009 03:29:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63,J_CHICKENPOX_73,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 03:29:38 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3O3TagY001818 for ; Thu, 23 Apr 2009 23:29:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n3O3TZlK028043 for ; Thu, 23 Apr 2009 23:29:36 -0400 Received: from lindt.uglyboxes.com (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n3O3TX6e008258 for ; Thu, 23 Apr 2009 23:29:34 -0400 Message-ID: <49F13213.2020103@redhat.com> Date: Fri, 24 Apr 2009 03:29:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: insight Subject: [PATCH] Fix Memory Window Preferences Content-Type: multipart/mixed; boundary="------------080208090205010307040207" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00023.txt.bz2 This is a multi-part message in MIME format. --------------080208090205010307040207 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 478 Hi, The other day I noticed that memory window preferences were really broken, so I've committed the following patch to fix them again. If anyone notices any problems, please let me know. Keith ChangeLog 2009-04-23 Keith Seitz * library/mempref.itb (build_win): Replace libgui's "Labelledframe" with the iwidget's LabeledFrame. Replaced all occurrances. * libarary/memwin.itb (create_prefs): Use ManagedWin::open_dlg instead of ManagedWin::open. --------------080208090205010307040207 Content-Type: text/plain; name="memwin.patach" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="memwin.patach" Content-length: 3667 Index: library/mempref.itb =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/library/mempref.itb,v retrieving revision 1.7 diff -u -p -r1.7 mempref.itb --- library/mempref.itb 24 Jan 2006 01:32:26 -0000 1.7 +++ library/mempref.itb 24 Apr 2009 03:25:54 -0000 @@ -1,5 +1,5 @@ # Memory display preferences window for Insight. -# Copyright (C) 1998, 1999, 2002, 2003, 2006 Red Hat +# Copyright (C) 1998, 1999, 2002, 2003, 2006, 2009 Red Hat, Inc # # This program is free software; you can redistribute it and/or modify it # under the terms of the GNU General Public License (GPL) as published by @@ -72,8 +72,8 @@ itcl::body MemPref::build_win {} { frame $itk_interior.f.b # SIZE - Labelledframe $f.f1 -anchor nw -text Size - set fr [$f.f1 get_frame] + iwidgets::Labeledframe $f.f1 -labelpos nw -labeltext [gettext "Size"] + set fr [$f.f1 childsite] set Widgets(rb-Byte) [radiobutton $fr.1 -variable [scope gsize] -text Byte \ -value 1 -command [code $this enable_format]] @@ -91,8 +91,8 @@ itcl::body MemPref::build_win {} { grid $fr.2 $fr.8 $fr.d -sticky w -padx 4 # FORMAT - Labelledframe $f.f2 -anchor nw -text Format - set fr [$f.f2 get_frame] + iwidgets::Labeledframe $f.f2 -labelpos nw -labeltext [gettext "Format"] + set fr [$f.f2 childsite] set Widgets(rb-binary) [radiobutton $fr.1 -variable [scope gformat] \ -text Binary -value t] set Widgets(rb-octal) [radiobutton $fr.2 -variable [scope gformat] \ @@ -108,7 +108,8 @@ itcl::body MemPref::build_win {} { grid $fr.4 $fr.5 x -sticky w -padx 4 # TOTAL BYTES - Labelledframe $f.fx -anchor nw -text "Number of Bytes" + iwidgets::Labeledframe $f.fx -labelpos nw \ + -labeltext [gettext "Number of Bytes"] if {$gnumbytes == 0} { set gnumbytes $default_numbytes @@ -117,7 +118,7 @@ itcl::body MemPref::build_win {} { set gvar 1 } - set fr [$f.fx get_frame] + set fr [$f.fx childsite] set Widgets(rb-win_size) [radiobutton $fr.1 -variable [scope gvar] -text "Depends on window size" \ -value 0 -command [code $this toggle_size_control]] frame $fr.2 @@ -143,8 +144,9 @@ itcl::body MemPref::build_win {} { grid columnconfigure $fr 1 -weight 1 # MISC - Labelledframe $f.1 -anchor nw -text "Miscellaneous" - set fr [$f.1 get_frame] + iwidgets::Labeledframe $f.1 -labelpos nw \ + -labeltext [gettext "Miscellaneous"] + set fr [$f.1 childsite] frame $fr.1 label $fr.1.plabel -height 1 -width 1 -bg $color -relief raised set Widgets(b-color) [button $fr.1.pc -text "Change color..." \ Index: library/memwin.itb =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/library/memwin.itb,v retrieving revision 1.25 diff -u -p -r1.25 memwin.itb --- library/memwin.itb 9 Feb 2008 01:23:42 -0000 1.25 +++ library/memwin.itb 24 Apr 2009 03:25:54 -0000 @@ -1,5 +1,5 @@ # Memory display window class definition for Insight. -# Copyright (C) 1998, 1999, 2001, 2002, 2005, 2008 Red Hat, Inc. +# Copyright (C) 1998, 1999, 2001, 2002, 2005, 2008, 2009 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify it # under the terms of the GNU General Public License (GPL) as published by @@ -236,7 +236,7 @@ itcl::body MemWin::create_prefs {} { set rheight [lindex [$itk_component(table) bbox 0,0] 3] } - set prefs_win [ManagedWin::open MemPref -force -over $this\ + set prefs_win [ManagedWin::open_dlg MemPref -force -over $this\ -transient -win $this \ -size $size -format $format -numbytes $numbytes \ -bpr $bytes_per_row -ascii $ascii \ --------------080208090205010307040207--