From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12013 invoked by alias); 25 Jan 2010 20:01:18 -0000 Received: (qmail 11615 invoked by uid 22791); 25 Jan 2010 20:01:17 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jan 2010 20:01:11 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0PK19Nm013713 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 Jan 2010 15:01:09 -0500 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0PK13Uh013552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 25 Jan 2010 15:01:08 -0500 Message-ID: <4B5DF87F.8010303@redhat.com> Date: Tue, 26 Jan 2010 02:09:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Lightning/1.0pre Thunderbird/3.0 MIME-Version: 1.0 To: Hui Zhu CC: insight@sourceware.org Subject: Re: Build insight cvs-head get error References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------060909060903010304060601" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q1/txt/msg00018.txt.bz2 This is a multi-part message in MIME format. --------------060909060903010304060601 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 461 On 01/25/2010 12:21 AM, Hui Zhu wrote: > ../../src/gdb/gdbtk/generic/gdbtk-cmds.c: In function 'gdb_set_inferior_args': > ../../src/gdb/gdbtk/generic/gdbtk-cmds.c:867: error: void value not > ignored as it ought to be I've checked in the attached patch for this. Keith ChangeLog 2010-01-25 Keith Seitz * generic/gdbtk-cmds.c (gdb_set_inferior_args): set_inferior_args now works as expected. Do not strdup/free the argument string. --------------060909060903010304060601 Content-Type: text/plain; name="set_inferior_args.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="set_inferior_args.patch" Content-length: 753 Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.114 retrieving revision 1.115 diff -u -p -r1.114 -r1.115 --- generic/gdbtk-cmds.c 4 Jan 2010 20:14:46 -0000 1.114 +++ generic/gdbtk-cmds.c 25 Jan 2010 19:59:29 -0000 1.115 @@ -859,13 +859,7 @@ gdb_set_inferior_args (ClientData client } args = Tcl_GetStringFromObj (objv[1], NULL); - - /* The xstrdup/xfree stuff is so that we maintain a coherent picture - for gdb. I would expect the accessors to do this, but they - don't. */ - args = xstrdup (args); - args = set_inferior_args (args); - xfree (args); + set_inferior_args (args); return TCL_OK; } --------------060909060903010304060601--