From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6709 invoked by alias); 17 Mar 2010 17:57:37 -0000 Received: (qmail 6701 invoked by uid 22791); 17 Mar 2010 17:57:35 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Mar 2010 17:57:27 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2HHvQoh004095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Mar 2010 13:57:26 -0400 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2HHvM6i008395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Mar 2010 13:57:25 -0400 Message-ID: <4BA11802.8050909@redhat.com> Date: Thu, 18 Mar 2010 03:39:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc11 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Gene Smith CC: insight@sources.redhat.com Subject: Re: undefined reference to `set_breakpoint' References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------060805050308050807090005" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q1/txt/msg00037.txt.bz2 This is a multi-part message in MIME format. --------------060805050308050807090005 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 562 On 03/17/2010 10:33 AM, Tom Tromey wrote: >>>>>> "Gene" == Gene Smith writes: > No, this is due to a change to gdb without a corresponding fix to > insight. This happens from time to time. Do you want to test the attach patch? [I'm off the rest of the week, or I would probably have occasion to put it through its paces.] Let me know if this works -- it was okay in preliminary testing. Keith ChangeLog 2010-03-17 Keith Seitz * generic/gdbtk-bp.c (gdb_set_bp): set_breakpoint is no more. Use create_breakpoint. --------------060805050308050807090005 Content-Type: text/plain; name="set_breakpoint.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="set_breakpoint.patch" Content-length: 1181 Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.33 diff -u -p -r1.33 gdbtk-bp.c --- generic/gdbtk-bp.c 15 Jan 2010 22:37:18 -0000 1.33 +++ generic/gdbtk-bp.c 17 Mar 2010 17:56:54 -0000 @@ -1,5 +1,5 @@ /* Tcl/Tk command definitions for Insight - Breakpoints. - Copyright (C) 2001, 2002, 2008, 2009 Free Software Foundation, Inc. + Copyright (C) 2001, 2002, 2008, 2009, 2010 Free Software Foundation, Inc. This file is part of GDB. @@ -530,9 +530,16 @@ gdb_set_bp (ClientData clientData, Tcl_I TRY_CATCH (e, RETURN_MASK_ALL) { - set_breakpoint (get_current_arch (), address, condition, - 0 /* hardwareflag */, temp, thread, ignore_count, - pending, enabled); + create_breakpoint (get_current_arch (), address, condition, thread, + 0 /* condition and thread are valid */, + temp, + 0 /* hardware flag */, + 0 /* trace flag */, + ignore_count, + (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE), + NULL /* breakpoint ops */, + 0 /* from_tty */, + enabled); } if (e.reason < 0) --------------060805050308050807090005--