From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12656 invoked by alias); 2 Apr 2010 23:42:41 -0000 Received: (qmail 12629 invoked by uid 22791); 2 Apr 2010 23:42:34 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Apr 2010 23:42:28 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o32NgPhR004279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Apr 2010 19:42:25 -0400 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o32NgJEh005745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Apr 2010 19:42:21 -0400 Message-ID: <4BB680DB.3080002@redhat.com> Date: Fri, 02 Apr 2010 23:42:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc11 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Hui Zhu CC: insight@sourceware.org Subject: [PATCH] Re: Build gdbtk-bp.c get error References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------020304090707050208020101" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q2/txt/msg00002.txt.bz2 This is a multi-part message in MIME format. --------------020304090707050208020101 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 741 On 04/01/2010 10:56 PM, Hui Zhu wrote: > ../../src/gdb/gdbtk/generic/gdbtk-bp.c > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_breakpoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:365: error: dereferencing > pointer to incomplete type > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'gdb_get_tracepoint_info': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:775: error: dereferencing > pointer to incomplete type Gdb is up to it again... I've committed the attached patch to correct this. Keith ChangeLog 2010-04-02 Keith Seitz * generic/gdbtk-bp.c (gdb_get_breakpoint_info): Use breakpoint_commands to access breakpoint commands. (gdb_get_tracepoint_info): Likewise for tracepoint actions. --------------020304090707050208020101 Content-Type: text/plain; name="more-bp-command-tweaks.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="more-bp-command-tweaks.patch" Content-length: 1112 Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.35 diff -u -p -r1.35 gdbtk-bp.c --- generic/gdbtk-bp.c 30 Mar 2010 16:48:31 -0000 1.35 +++ generic/gdbtk-bp.c 2 Apr 2010 23:37:58 -0000 @@ -362,7 +362,7 @@ gdb_get_breakpoint_info (ClientData clie Tcl_NewIntObj (b->ignore_count)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, - get_breakpoint_commands (b->commands ? b->commands->commands : NULL)); + get_breakpoint_commands ((breakpoint_commands (b)) ? breakpoint_commands (b) : NULL)); Tcl_ListObjAppendElement (NULL, result_ptr->obj_ptr, Tcl_NewStringObj (b->cond_string, -1)); @@ -772,7 +772,7 @@ gdb_get_tracepoint_info (ClientData clie action_list = Tcl_NewObj (); if (tp->commands != NULL) { - for (cl = tp->commands->commands; cl != NULL; cl = cl->next) + for (cl = breakpoint_commands (tp); cl != NULL; cl = cl->next) { Tcl_ListObjAppendElement (interp, action_list, Tcl_NewStringObj (cl->line, -1)); --------------020304090707050208020101--