From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13826 invoked by alias); 19 Jun 2010 18:01:41 -0000 Received: (qmail 13489 invoked by uid 22791); 19 Jun 2010 18:01:41 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Jun 2010 18:01:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5JI1Wj9018100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 19 Jun 2010 14:01:32 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5JI1SBw006530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 19 Jun 2010 14:01:30 -0400 Message-ID: <4C1D05F8.7070208@redhat.com> Date: Sat, 19 Jun 2010 18:01:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Pierre Muller CC: insight@sourceware.org Subject: Re: [OBV] Fix Build gdbtk-cmds.c get error References: <001201cb0f35$04c60240$0e5206c0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001201cb0f35$04c60240$0e5206c0$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q2/txt/msg00031.txt.bz2 On 06/18/2010 03:24 PM, Pierre Muller wrote: > I checked the following in: > Note that it fixes the val_print problem > and also cygwin specific problems to > allow compilation with both 1.5 and 1.7 cygwin... Aside from the cygwin stuff, I had a similar patch that I simply forgot to check in. Thank you for beating me to it! :-) > For the cygwin_conv_path function, > I used the same macros as in gdb/windows-nat.c source. > > Please feel free to suggest better > fixes. That all looks okay. If anything is amiss, it can be addressed in time. > I didn't dare to change > GDB_val_print function, as this could have implications > for tcl/tk scripts... Am I right on this? GDB_val_print is simply a wrapper which prevents gdb from longjmp'ing out of the Tcl interpreter. With the advent of "exceptions," the wrappers aren't really necessary any more. Maybe I'll clean this up some time... > PS: I only fixed compilation and I am still unable to > really test cygwin insight :( I can see if my twelve year old box still boots and give it a quick sanity check. Thanks again for the patch, Keith