From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11701 invoked by alias); 4 Jul 2010 18:13:07 -0000 Received: (qmail 11690 invoked by uid 22791); 4 Jul 2010 18:13:07 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 04 Jul 2010 18:13:02 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o64ID0oT013946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 4 Jul 2010 14:13:00 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o64ICvr5015036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 4 Jul 2010 14:12:59 -0400 Message-ID: <4C30CF29.7090009@redhat.com> Date: Sun, 04 Jul 2010 18:13:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Hui Zhu CC: insight@sourceware.org Subject: Re: Build gdbtk-cmds.c get error References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------020306030306000407010501" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2010-q3/txt/msg00007.txt.bz2 This is a multi-part message in MIME format. --------------020306030306000407010501 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 421 On 07/04/2010 01:20 AM, Hui Zhu wrote: > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:558: error: too many arguments > to function 'create_breakpoint' I've committed the attached patch to fix this, another API change in gdb. Thank you for bringing this to my attention. Keith ChangeLog 2010-07-04 Keith Seitz * generic/gdbtk-bp.c (gdb_set_bp): Update arguments for API change in create_breakpoint. --------------020306030306000407010501 Content-Type: text/plain; name="update-create-breakpoint-api.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="update-create-breakpoint-api.patch" Content-length: 696 Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.36 diff -u -p -r1.36 gdbtk-bp.c --- generic/gdbtk-bp.c 2 Apr 2010 23:39:55 -0000 1.36 +++ generic/gdbtk-bp.c 4 Jul 2010 18:09:32 -0000 @@ -549,8 +549,7 @@ gdb_set_bp (ClientData clientData, Tcl_I create_breakpoint (get_current_arch (), address, condition, thread, 0 /* condition and thread are valid */, temp, - 0 /* hardware flag */, - 0 /* trace flag */, + bp_breakpoint /* type wanted */, ignore_count, (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE), NULL /* breakpoint ops */, --------------020306030306000407010501--