patch for insight-6.8.1

patch for insight-6.8.1

[Frank Duignan]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

I tried to build insight 6.8.1 for arm-elf and ran into man (terminal)
warnings.  These all related to ignored return values from function
calls.  I fixed these up and here is the diff.
I can mail the whole source tree if you like
f.

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 1914 bytes --]

diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/cli/cli-cmds.c /media/backup/frank/arm/build/insight-6.8-1/gdb/cli/cli-cmds.c
320a321
>   char * temp;
323c324
<   getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
---
>   temp=getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/eval.c /media/backup/frank/arm/build/insight-6.8-1/gdb/eval.c
1649c1649,1651
< 
---
> 	for (i=0;i<MAX_FORTRAN_DIMS;i++) {
> 		subscript_array[i]=array_size_array[i]=0;
> 	}
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/inflow.c /media/backup/frank/arm/build/insight-6.8-1/gdb/inflow.c
515a516
>   int n;
548c549
<       dup (tty);
---
>       n = dup (tty);
553c554
<       dup (tty);
---
>       n = dup (tty);
558c559
<       dup (tty);
---
>       n = dup (tty);
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/main.c /media/backup/frank/arm/build/insight-6.8-1/gdb/main.c
164a165,166
>  
>   char * temp;
191c193
<   getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
---
>   temp = getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/mi/mi-cmd-env.c /media/backup/frank/arm/build/insight-6.8-1/gdb/mi/mi-cmd-env.c
69a70
>   char *temp;
81c82
<   getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
---
>   temp = getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/top.c /media/backup/frank/arm/build/insight-6.8-1/gdb/top.c
1625a1626
>   char *temp;
1631c1632
<   getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
---
>   temp = getcwd (gdb_dirbuf, sizeof (gdb_dirbuf));
diff -r /media/backup/frank/arm/build/originals/insight-6.8-1/gdb/utils.c /media/backup/frank/arm/build/insight-6.8-1/gdb/utils.c
692c692
< 
---
>   ssize_t num;
707c707
< 	write (STDERR_FILENO, msg, sizeof (msg));
---
> 	num = write (STDERR_FILENO, msg, sizeof (msg));

Re: patch for insight-6.8.1

[Keith Seitz]

On 08/19/2010 11:46 AM, Frank Duignan wrote:
> I tried to build insight 6.8.1 for arm-elf and ran into man (terminal)
> warnings.  These all related to ignored return values from function
> calls.  I fixed these up and here is the diff.

Thanks for the diff. Have you tried a newer version, like a CVS 
snapshot? [Gdb also "unofficially" available via git, too.]

I know there hasn't been much movement on a new "official" release, but 
I am planning to do something when gdb officially releases 7.2. [FWIW, 
I've used weekly snapshots of insight+gdb for years. Almost never have a 
problem.]

The diffs you supplied all pertain to gdb's files, and I'll bet these 
are LONG since solved since 6.8.1. So I did a little digging...

 From what I can figure out, all the problems with getcwd have been 
addressed. As has the "write" in utils.c. "dup" is no longer used in 
inflow.c, so I'm guessing that's fixed, too.

That leaves one potential problem in eval.c (initializing the array).  I 
cannot tell you whether this has been addressed or not because the diff 
doesn't contain enough context information (please use "-u" option to 
diff next time).

I encourage you to try a snapshot or CVS/git checkout to see if any of 
these problems persist. You should report any further problems to the 
gdb mailing list (gdb@ instead of insight@).

Keith