From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14534 invoked by alias); 9 Apr 2011 04:26:12 -0000 Received: (qmail 14521 invoked by uid 22791); 9 Apr 2011 04:26:10 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Apr 2011 04:26:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p394Q3ib018990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 9 Apr 2011 00:26:03 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p394Q0Sg009135 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 9 Apr 2011 00:26:02 -0400 Message-ID: <4D9FDFD8.7080109@redhat.com> Date: Sat, 09 Apr 2011 04:26:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.38.b3pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: Hui Zhu CC: insight Subject: Re: [PATCH] Rotate ChangeLog, fix build issues References: <4D9F9BB2.1070904@redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------010301010105050400030304" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00002.txt.bz2 This is a multi-part message in MIME format. --------------010301010105050400030304 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1777 On 04/08/2011 09:14 PM, Hui Zhu wrote: > I am not sure, bug I got: > gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common > -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode > -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd > -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber > -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib > -DMI_OUT=1 -DTUI=1 -DGDBTK -I/usr/include/python2.6 > -I/usr/include/python2.6 -Wall -Wdeclaration-after-statement > -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused > -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts > -Werror -c -o gdbtk-bp.o -MT gdbtk-bp.o -MMD -MP -MF > .deps/gdbtk-bp.Tpo -I../../src/gdb/../libgui/src > -I/home/teawater/gdb/cvs/src/tcl/generic > -I/home/teawater/gdb/cvs/src/tk/generic > -DGDBTK_LIBRARY=\"/usr/local/share/insight1.0\" > -DSRC_DIR=\"/home/teawater/gdb/cvs/src/gdb\" > ../../src/gdb/gdbtk/generic/gdbtk-bp.c > ../../src/gdb/gdbtk/generic/gdbtk-bp.c: In function 'tracepoint_exists': > ../../src/gdb/gdbtk/generic/gdbtk-bp.c:834: error: too many arguments > to function 'decode_line_1' Gah! *Another* change. I missed it because I haven't updated my working directory in a week. I've committed the attached patch, which *should* fix it. Thank you for pointing that out. Keith ChangeLog 2011-04-08 Keith Seitz * generic/gdbtk-bp.c (tracepoint_exists): Remove recently removed "not_found_ptr" argument from call to decode_line_1. * generic/gdbtk-stack.c (gdb_get_vars_command): Likewise. * generic/gdbtk-cmds.c (gdb_get_line_command): Likewise. (gdb_get_file_command): Likewise. (gdb_get_function_command): Likewise. --------------010301010105050400030304 Content-Type: text/plain; name="insight-decode_line_1-not_found_ptr.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="insight-decode_line_1-not_found_ptr.patch" Content-length: 2477 Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.39 diff -u -p -r1.39 gdbtk-bp.c --- generic/gdbtk-bp.c 8 Apr 2011 23:32:42 -0000 1.39 +++ generic/gdbtk-bp.c 9 Apr 2011 04:24:26 -0000 @@ -831,7 +831,7 @@ tracepoint_exists (char *args) char *file = NULL; int result = -1; - sals = decode_line_1 (&args, 1, NULL, 0, NULL, NULL); + sals = decode_line_1 (&args, 1, NULL, 0, NULL); if (sals.nelts == 1) { resolve_sal_pc (&sals.sals[0]); Index: generic/gdbtk-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-cmds.c,v retrieving revision 1.119 diff -u -p -r1.119 gdbtk-cmds.c --- generic/gdbtk-cmds.c 8 Apr 2011 23:32:42 -0000 1.119 +++ generic/gdbtk-cmds.c 9 Apr 2011 04:24:27 -0000 @@ -961,7 +961,7 @@ gdb_get_line_command (ClientData clientD } args = Tcl_GetStringFromObj (objv[1], NULL); - sals = decode_line_1 (&args, 1, NULL, 0, NULL, NULL); + sals = decode_line_1 (&args, 1, NULL, 0, NULL); if (sals.nelts == 1) { Tcl_SetIntObj (result_ptr->obj_ptr, sals.sals[0].line); @@ -997,7 +997,7 @@ gdb_get_file_command (ClientData clientD } args = Tcl_GetStringFromObj (objv[1], NULL); - sals = decode_line_1 (&args, 1, NULL, 0, NULL, NULL); + sals = decode_line_1 (&args, 1, NULL, 0, NULL); if (sals.nelts == 1) { Tcl_SetStringObj (result_ptr->obj_ptr, @@ -1033,7 +1033,7 @@ gdb_get_function_command (ClientData cli } args = Tcl_GetStringFromObj (objv[1], NULL); - sals = decode_line_1 (&args, 1, NULL, 0, NULL, NULL); + sals = decode_line_1 (&args, 1, NULL, 0, NULL); if (sals.nelts == 1) { resolve_sal_pc (&sals.sals[0]); Index: generic/gdbtk-stack.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-stack.c,v retrieving revision 1.35 diff -u -p -r1.35 gdbtk-stack.c --- generic/gdbtk-stack.c 8 Apr 2011 23:32:42 -0000 1.35 +++ generic/gdbtk-stack.c 9 Apr 2011 04:24:27 -0000 @@ -298,7 +298,7 @@ gdb_get_vars_command (ClientData clientD if (objc == 2) { args = Tcl_GetStringFromObj (objv[1], NULL); - sals = decode_line_1 (&args, 1, NULL, 0, NULL, NULL); + sals = decode_line_1 (&args, 1, NULL, 0, NULL); if (sals.nelts == 0) { gdbtk_set_result (interp, "error decoding line"); --------------010301010105050400030304--