From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32319 invoked by alias); 2 Aug 2011 18:50:10 -0000 Received: (qmail 32309 invoked by uid 22791); 2 Aug 2011 18:50:09 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 18:49:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p72InofC011531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Aug 2011 14:49:50 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p72InmTR002634 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 2 Aug 2011 14:49:49 -0400 Message-ID: <4E3846CB.5020900@redhat.com> Date: Tue, 02 Aug 2011 18:50:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: insight Subject: Re: [PATCH] Recent GDB prompt/bp API updates References: <4E372454.7010204@redhat.com> In-Reply-To: <4E372454.7010204@redhat.com> Content-Type: multipart/mixed; boundary="------------080301020102020909000301" X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2011-q3/txt/msg00007.txt.bz2 This is a multi-part message in MIME format. --------------080301020102020909000301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 373 On 08/01/2011 03:10 PM, Keith Seitz wrote: > If there are any problems, please let me know. There was a problem: breakpoints could not be set through the Source Window. I have committed the attach patch to correct this. Keith ChangeLog 2011-08-02 Keith Seitz * generic/gdbtk-bp.c (gdb_set_bp): Pass a valid breakpoint_ops to create_breakpoint. --------------080301020102020909000301 Content-Type: text/plain; name="breakpoint_ops.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="breakpoint_ops.patch" Content-length: 587 Index: generic/gdbtk-bp.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-bp.c,v retrieving revision 1.42 diff -u -p -r1.42 gdbtk-bp.c --- generic/gdbtk-bp.c 1 Aug 2011 22:08:20 -0000 1.42 +++ generic/gdbtk-bp.c 2 Aug 2011 18:05:04 -0000 @@ -540,7 +540,7 @@ gdb_set_bp (ClientData clientData, Tcl_I bp_breakpoint /* type wanted */, ignore_count, (pending ? AUTO_BOOLEAN_TRUE : AUTO_BOOLEAN_FALSE), - NULL /* breakpoint ops */, + &bkpt_breakpoint_ops, 0 /* from_tty */, enabled, 0); } --------------080301020102020909000301--