From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4078 invoked by alias); 28 Feb 2012 21:58:20 -0000 Received: (qmail 4070 invoked by uid 22791); 28 Feb 2012 21:58:20 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Feb 2012 21:58:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1SLw7mv002695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Feb 2012 16:58:07 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1SLw47f018193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Feb 2012 16:58:06 -0500 Message-ID: <4F4D4DEC.5030705@redhat.com> Date: Tue, 28 Feb 2012 21:58:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Jeffrey Armstrong CC: insight@sourceware.org Subject: Re: Patch for setting breakpoints in source window References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00013.txt.bz2 On 12/06/2011 11:23 AM, Jeffrey Armstrong wrote: > I've been experiencing issues with Insight compiled via MinGW under > Windows where the user cannot set breakpoints via the source window > under certain circumstances. The culprit appears to be a failure to > wrap the filename in quotes when passing it to gdb. Normally this > isn't a problem, but when a space is present in the full path name, as > is so common on Windows, the breakpoint fails to be set. I've > attached a simple patch below that shouldn't have any detrimental side > effects on other OSes. Hi, Thank you for the patch. You're right, that should not present any problems on any platforms. I've committed your patch with the following ChangeLog: 2012-02-28 Keith Seitz From Jeffrey Armstrong : * library/srctextwin.itb (lookup_line): Quote the filename to gdb_set_bp. Keith