From: Roland Schwingel <roland@onevision.com>
To: insight@sourceware.org
Subject: [PATCH] Fix global preferences
Date: Mon, 19 Mar 2012 12:20:00 -0000 [thread overview]
Message-ID: <4F672484.6080501@onevision.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
Hi..
When using tk 8.6 global preferences do not open any more. It complains
a packing problem. The attached patch fixes it. It is backward
compatible to at least tk 8.4.
Changelog:
2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
* library/globalpref.itb (_build_win): Remove unneeded debug call.
Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small
reformatting.
Any comments? Is this ok?
This is the last patch for today and finishes my patch series for gdbtk
for now. Next I will (most likely) cover libgui.
Roland
[-- Attachment #2: pack_globalpref.itb.patch --]
[-- Type: text/plain, Size: 2042 bytes --]
--- gdbtk_orig/library/globalpref.itb 2008-08-03 00:08:32.000000000 +0200
+++ gdbtk/library/globalpref.itb 2012-03-09 16:22:34.047717300 +0100
@@ -77,14 +77,13 @@
# ------------------------------------------------------------------
itcl::body GlobalPref::_build_win {} {
global gdbtk_platform GDBTK_LIBRARY
- debug
frame $itk_interior.f
frame $itk_interior.x
set frame $itk_interior.f
# Icons
frame $frame.icons
- label $frame.icons.lab -text "Icons "
+ label $frame.icons.lab -text "Icons: "
combobox::combobox $frame.icons.cb -editable 0 -maxheight 10\
-command [code $this _change_icons] -bg $::Colors(textbg)
@@ -132,6 +131,7 @@
# can be saved in the init file. A way should be provided
# to rescan the font list, without deleting the entry from the
# init file.
+
set font_cache [pref get gdb/font_cache]
# get list of fonts, removing some that typically
@@ -187,7 +187,6 @@
_make_font_item $f default "Default Font:" $fam
_make_font_item $f status "Status Bar Font:" $fam
-
iwidgets::Labeledframe $frame.misc -labelpos nw -labeltext "Misc"
set f [$frame.misc childsite]
@@ -249,11 +248,11 @@
}
# make buttons
- button $itk_interior.x.ok -text OK -underline 0 -width 7 -command [code $this _ok]
+ button $itk_interior.x.ok -text OK -width 7 -underline 0 -command [code $this _ok]
button $itk_interior.x.apply -text Apply -width 7 -underline 0 -command [code $this _apply]
button $itk_interior.x.cancel -text Cancel -width 7 -underline 0 -command [code $this _cancel]
- pack $itk_interior.x.ok $itk_interior.x.apply $itk_interior.x.cancel -side left
standard_button_box $itk_interior.x
+ pack $itk_interior.x -side left
pack $itk_interior.x -fill x -padx 5 -pady 5 -side bottom
pack $itk_interior.f -fill both -expand yes -padx 5 -pady 5
@@ -268,7 +267,6 @@
_resize_font_item_height
pack propagate $itk_interior.f 0
-
}
# ------------------------------------------------------------------
# PRIVATE METHOD: _make_font_item
next reply other threads:[~2012-03-19 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 12:20 Roland Schwingel [this message]
2012-03-29 23:56 ` Keith Seitz
2012-03-30 9:19 Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F672484.6080501@onevision.com \
--to=roland@onevision.com \
--cc=insight@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).