From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3788 invoked by alias); 27 Mar 2012 15:18:04 -0000 Received: (qmail 3747 invoked by uid 22791); 27 Mar 2012 15:18:02 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BT,TW_CP,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Mar 2012 15:17:45 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2RFHSi3015381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Mar 2012 11:17:33 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2REitnZ019887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 Mar 2012 10:44:57 -0400 Message-ID: <4F71D266.70601@redhat.com> Date: Tue, 27 Mar 2012 15:18:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Roland Schwingel CC: insight@sourceware.org Subject: Re: [PATCH] Remove deprecated access to tcl internal variables References: <4F716889.2080603@onevision.com> In-Reply-To: <4F716889.2080603@onevision.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00038.txt.bz2 On 03/27/2012 12:13 AM, Roland Schwingel wrote: > Sorry... Sometimes it is hard to switch between the styles. I surely > want to follow the GCS when submitting patches. Our company style is > just (in some areas) vice versa. Not a problem -- it happens to everyone. :-) > If you give the ok to my patch(es) I can also > do these final reformatting during commit. That will be best/easiest. One other thing I noticed: > else > - actual_len = strlen (gdbtk_interp->result); > + { Here ^ > + const char *tclResult = Tcl_GetStringResult(gdbtk_interp); > + actual_len = strlen (tclResult); > > /* Truncate the string if it is too big for the caller's buffer. */ > if (actual_len >= sizeof_buf) > actual_len = sizeof_buf - 1; > > - memcpy (buf, gdbtk_interp->result, actual_len); > + memcpy (buf,tclResult, actual_len); > buf[actual_len] = '\0'; > return actual_len; > + } > } and here^ the identation level is off. Please adjust to follow the rest of the code. [These should be emacs-default indentations IIRC.] > I did not change behaviour here Keith. gdbtk_read() behaves the same as > before it just takes a small shortcut in case gdbtk_console_read has failed > (for some reasons). Yes, you are right. I completely missed that. In any case, please add a ChangeLog entry for it, adjust the two formatting/CS discrepancies and this patch is good to go in. Thanks! Keith