From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5475 invoked by alias); 28 Mar 2012 14:53:24 -0000 Received: (qmail 5458 invoked by uid 22791); 28 Mar 2012 14:53:22 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Mar 2012 14:53:08 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id q2SEr0SE016090 for ; Wed, 28 Mar 2012 16:53:05 +0200 Received: from [192.168.5.32] ([192.168.5.32]) by sanders.onevision.de (Lotus Domino Release 8.5.1FP3) with ESMTP id 2012032816525545-4455 ; Wed, 28 Mar 2012 16:52:55 +0200 Message-ID: <4F7325C6.6010807@onevision.com> Date: Wed, 28 Mar 2012 14:53:00 -0000 From: Roland Schwingel User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: insight@sourceware.org Subject: Re: [PATCH] Remove deprecated access to tcl internal variables Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-15; format=flowed Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00039.txt.bz2 Hi Keith, insight-owner@sourceware.org wrote on 27.03.2012 16:44:54: > In any case, please add a > ChangeLog entry for it, adjust the two formatting/CS discrepancies and > this patch is good to go in. I corrected the formatting of function calls and indents and expanded the changelog and checked it in now. New changelog: 2012-03-28 Roland Schwingel * generic/gdbtk.c (gdbtk_init,tk_command): Replace deprecated access to tcl interpreter result string with Tcl_GetStringResult(). * generic/gdbtk-hooks.c (gdbtk_read,gdbtk_readline,gdbtk_load_hash) (gdbtk_query): Likewise. (gdbtk_read): Simplified error handling in case "gdbtk_console_read" fails. Some reformatting. Thanks for reviewing. :-) Do you know when you will find time to look at my other patches? At least the next four of my bulk are quite trivial. Thanks, Roland