From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <insight-return-6973-listarch-insight=sources.redhat.com@sourceware.org>
Received: (qmail 14252 invoked by alias); 29 Mar 2012 23:02:38 -0000
Received: (qmail 14241 invoked by uid 22791); 29 Mar 2012 23:02:37 -0000
X-SWARE-Spam-Status: No, hits=-6.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_FD,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 23:02:24 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TN2Cv9011086	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 29 Mar 2012 19:02:12 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2TN29EE018133	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Thu, 29 Mar 2012 19:02:11 -0400
Message-ID: <4F74E9F1.20804@redhat.com>
Date: Thu, 29 Mar 2012 23:02:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1
MIME-Version: 1.0
To: Roland Schwingel <roland@onevision.com>
CC: insight@sourceware.org
Subject: Re: [PATCH] Add missing prototype in gdbtk.c
References: <4F67221F.2020906@onevision.com>
In-Reply-To: <4F67221F.2020906@onevision.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact insight-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <insight.sourceware.org>
List-Subscribe: <mailto:insight-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/insight/>
List-Post: <mailto:insight@sourceware.org>
List-Help: <mailto:insight-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: insight-owner@sourceware.org
X-SW-Source: 2012-q1/txt/msg00042.txt.bz2

On 03/19/2012 05:10 AM, Roland Schwingel wrote:
> Changelog:
>
> 2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
>
> * generic/gdbtk.c: Add prototype for close_bfds().
>
> Any comments? Is this ok?

Hmm. There already appears to be a declaration for this in gdbtk.h:

#ifdef _WIN32
extern void close_bfds ();
#endif /* _WIN32 */

Perhaps that check needs updating to "#if defined(_WIN32) || 
defined(_WIN64)"?

[Consider that change pre-approved with updated ChangeLog entry.]

Keith