From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17573 invoked by alias); 29 Mar 2012 23:17:56 -0000 Received: (qmail 17565 invoked by uid 22791); 29 Mar 2012 23:17:55 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 23:17:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TNHSYV006197 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Mar 2012 19:17:29 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q2TN4HSe023039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Mar 2012 19:04:19 -0400 Message-ID: <4F74EA71.1000004@redhat.com> Date: Thu, 29 Mar 2012 23:17:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Roland Schwingel CC: insight@sourceware.org Subject: Re: [PATCH] Allow onlinehelp to work on native windows References: <4F671D87.8060909@onevision.com> In-Reply-To: <4F671D87.8060909@onevision.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00044.txt.bz2 On 03/19/2012 04:50 AM, Roland Schwingel wrote: > Hello, > > Here comes a simple patch allowing insight's onlinehelp also to be > opened on native windows, not only on cygwin. > It still continues to work on cygwin, too. > > Changelog: > > 2012-03-19 Roland Schwingel > > * generic/gdbtk.c: (gdbtk_init): Move call to ide_create_shell_execute_command > to generic windows section. This line is too long. Please wrap after "call". [We try to keep line lengths < 80 characters.] > Any comments? Is this ok? Ok with that change. Keith