[PATCH] Fix global preferences

[PATCH] Fix global preferences

[Roland Schwingel]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

Hi..


When using tk 8.6 global preferences do not open any more. It complains 
a packing problem. The attached patch fixes it. It is backward 
compatible to at least tk 8.4.

Changelog:

2012-03-19  Roland Schwingel <roland.schwingel@onevision.com>

         * library/globalpref.itb (_build_win): Remove unneeded debug call.
         Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small
         reformatting.

Any comments? Is this ok?

This is the last patch for today and finishes my patch series for gdbtk 
for now. Next I will (most likely) cover libgui.

Roland


[-- Attachment #2: pack_globalpref.itb.patch --]
[-- Type: text/plain, Size: 2042 bytes --]

--- gdbtk_orig/library/globalpref.itb	2008-08-03 00:08:32.000000000 +0200
+++ gdbtk/library/globalpref.itb	2012-03-09 16:22:34.047717300 +0100
@@ -77,14 +77,13 @@
 # ------------------------------------------------------------------
 itcl::body GlobalPref::_build_win {} {
   global gdbtk_platform GDBTK_LIBRARY
-  debug
   frame $itk_interior.f
   frame $itk_interior.x
   set frame $itk_interior.f
   
   # Icons
   frame $frame.icons
-  label $frame.icons.lab -text "Icons "
+  label $frame.icons.lab -text "Icons: "
   combobox::combobox $frame.icons.cb -editable 0 -maxheight 10\
     -command [code $this _change_icons] -bg $::Colors(textbg)
   
@@ -132,6 +131,7 @@
   # can be saved in the init file. A way should be provided
   # to rescan the font list, without deleting the entry from the
   # init file.
+
   set font_cache [pref get gdb/font_cache]
 
   # get list of fonts, removing some that typically
@@ -187,7 +187,6 @@
   _make_font_item $f default "Default Font:" $fam
   _make_font_item $f status  "Status Bar Font:" $fam
 
-
   iwidgets::Labeledframe $frame.misc -labelpos nw -labeltext "Misc"
   set f [$frame.misc childsite]
 
@@ -249,11 +248,11 @@
   }
 
   # make buttons
-  button $itk_interior.x.ok -text OK -underline 0 -width 7 -command [code $this _ok]
+  button $itk_interior.x.ok -text OK -width 7 -underline 0 -command [code $this _ok]
   button $itk_interior.x.apply -text Apply -width 7 -underline 0 -command [code $this _apply]
   button $itk_interior.x.cancel -text Cancel -width 7 -underline 0 -command [code $this _cancel]
-  pack $itk_interior.x.ok $itk_interior.x.apply $itk_interior.x.cancel -side left
   standard_button_box $itk_interior.x
+  pack $itk_interior.x -side left
 
   pack $itk_interior.x -fill x -padx 5 -pady 5 -side bottom
   pack $itk_interior.f -fill both -expand yes -padx 5 -pady 5
@@ -268,7 +267,6 @@
 
   _resize_font_item_height
   pack propagate $itk_interior.f 0
-
 }
 # ------------------------------------------------------------------
 #  PRIVATE METHOD:  _make_font_item

Re: [PATCH] Fix global preferences

[Keith Seitz]

On 03/19/2012 05:20 AM, Roland Schwingel wrote:
> Changelog:
>
> 2012-03-19 Roland Schwingel <roland.schwingel@onevision.com>
>
> * library/globalpref.itb (_build_win): Remove unneeded debug call.
> Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small
> reformatting.
>
> Any comments? Is this ok?

Ok.

> This is the last patch for today and finishes my patch series for gdbtk
> for now. Next I will (most likely) cover libgui.

Can I ask you to generate one diff per patch submission instead of one 
diff/attachment per file? It's a little easier to deal with.

I am really looking forward to trying this all out! [I have a mingw32 
installation somewhere that I randomly get to work, but i haven't tried 
64-bit yet.]

Keith

Re: [PATCH] Fix global preferences

[Roland Schwingel]

Hi ...

Keith Seitz <keiths@redhat.com> wrote on 30.03.2012 01:12:23:

 > > * library/globalpref.itb (_build_win): Remove unneeded debug call.
 > > Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small
 > > reformatting.
 > >
 > > Any comments? Is this ok?
 >
 > Ok.
Committed this now. Also updated copyright info in file.

 > Can I ask you to generate one diff per patch submission instead
 > of one diff/attachment per file? It's a little easier to deal with.
Ok. I will do so. As I made more changes all together it was easier
to me to work on file basis. But I can merge them later on again.

 > I am really looking forward to trying this all out! [I have a mingw32
 > installation somewhere that I randomly get to work, but i haven't
 > tried 64-bit yet.]
Yet I haven't sent all needed patches. I first wanted to get the patches 
I have already sent all be in to not loose track what is in and what 
not. If all my patches are in next would be to update iwidgets and itcl. 
If this is done it would be required to update tcl/tk to 8.6 for 64bit 
windows.

 From this point on insight could be build for windows 64bit using 
mingw-w64 toolchain and autotools machinery. I have to confess that I am 
at present not building using autotools machinery for myself. I am using 
our own company build system which gives me more flexibility. It uses 
mingw-w64 compilers for both 32 and 64bit windows and the very same 
compiler also for linux. It is also driven by gnu make but has its own 
build rules and project types. I am building ALL needed dependencies 
with it on all platforms. So everything is always all of a piece on all 
platforms. This avoids nearly all system setup specific little problems 
and is also faster. I can build a win32/win64 and linux version each all 
debug and release from full scratch with all needed libraries 
(tcl/tk/expat/zlib/gdb/insight and so on) just within around 9 minutes 
on an older Intel Q6600 cpu.

Before sending out patches to you I am always building with a stock 
mingw32 (and a native OpenSuse 11.4) to avoid any regressions and 
surprises here. At present you can't build for win64 until I am fully 
done with my backmerge. You can build for win32 using mingw32.

Beside of my insight patches I am having a patch pending in tk 8.6 
itself for windows geometry handling (support for dual/multihead) and a 
patch in gdb itself to allow stepping into dll code on windows 64bit.
(for the later I am waiting to get my copyright assignment request 
processed by gnu.)

If you want to test on windows I can also supply you prebuildt binaries 
for both 32 and 64bit windows. Just give me a note.

At present I am having 2 bigger problems left with my insight. One are 
some strange symtab problems when debugging Objective C code using 
insight. This problem is only present within insight not gdb build from 
the very same codebase and I do have sometimes some rare crashes of 
insight and gdb itself on windows which I have to hunt down.

Roland