From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24659 invoked by alias); 29 Mar 2012 23:56:36 -0000 Received: (qmail 24650 invoked by uid 22791); 29 Mar 2012 23:56:35 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BT,TW_DB,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Mar 2012 23:56:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2TNu4IQ016327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Mar 2012 19:56:04 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2TNCNOv004941 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 29 Mar 2012 19:12:25 -0400 Message-ID: <4F74EC57.50509@redhat.com> Date: Thu, 29 Mar 2012 23:56:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: Roland Schwingel CC: insight@sourceware.org Subject: Re: [PATCH] Fix global preferences References: <4F672484.6080501@onevision.com> In-Reply-To: <4F672484.6080501@onevision.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact insight-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: insight-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00046.txt.bz2 On 03/19/2012 05:20 AM, Roland Schwingel wrote: > Changelog: > > 2012-03-19 Roland Schwingel > > * library/globalpref.itb (_build_win): Remove unneeded debug call. > Fix packing of OK/Apply/Cancel buttons for newer tk versions. Small > reformatting. > > Any comments? Is this ok? Ok. > This is the last patch for today and finishes my patch series for gdbtk > for now. Next I will (most likely) cover libgui. Can I ask you to generate one diff per patch submission instead of one diff/attachment per file? It's a little easier to deal with. I am really looking forward to trying this all out! [I have a mingw32 installation somewhere that I randomly get to work, but i haven't tried 64-bit yet.] Keith