Re: [PATCH] libgui: Adjust windows default fonts

Re: [PATCH] libgui: Adjust windows default fonts

[Roland Schwingel]

Hi...

Keith Seitz <keiths@redhat.com> wrote on 30.03.2012 01:24:35:

 > > 2012-03-22 Roland Schwingel<roland.schwingel@onevision.com>
 > > * library/looknfeel.tcl (standard_look_and_feel): Change default
 > > fonts on windows. Default and status font is now Tahoma size 10.
 > > Source font is now Lucida Console size 9.
 > >
 > > Any comments? Is this ok?
 >
 > Ok.
Committed and updated copyright infos as wished.

Thanks,

Roland

Re: [PATCH] libgui: Adjust windows default fonts

[Keith Seitz]

On 03/22/2012 07:54 AM, Roland Schwingel wrote:
> Changelog:
>
> 2012-03-22 Roland Schwingel<roland.schwingel@onevision.com>
>
> * library/looknfeel.tcl (standard_look_and_feel): Change default
> fonts on windows. Default and status font is now Tahoma size 10.
> Source font is now Lucida Console size 9.
>
> Any comments? Is this ok?

Ok.

Please update the copyright date at the top of the file (and any other 
file that you commit patches to). I believe gdb uses ranges nowadays, so 
"1997-2012" is probably okay. Wow. Cygnus. That should be changed to 
"Red Hat, Inc."

[I've been pretty remiss about monitoring/fixing this.]

Keith

[PATCH] libgui: Adjust windows default fonts

[Roland Schwingel]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi...

libgui sets a bunch of default fonts which are giving the UI a quite
heavy/fat look on windows. Attached you find a small patch that uses
smaller fonts on windows. This results in roughly 30% more space in
source view and nicer looking panels. The changed fonts are at least
present since windows NT 4.0 - also since 1996 - so we can use them just
nicely.

Attached you find the small patch. Originally I wanted to attach 2 screenshots
but the mail got rejected by the mailinglist software. If someone is
interested I can send them seperately.

The patch is windows only!

Changelog:

2012-03-22  Roland Schwingel<roland.schwingel@onevision.com>

      * library/looknfeel.tcl (standard_look_and_feel): Change default
      fonts on windows. Default and status font is now Tahoma size 10.
      Source font is now Lucida Console size 9.

Any comments? Is this ok?

Roland



[-- Attachment #2: libgui_win_defaults.patch --]
[-- Type: text/plain, Size: 997 bytes --]

diff -ruN libgui_orig/library/looknfeel.tcl libgui/library/looknfeel.tcl
--- libgui_orig/library/looknfeel.tcl	2002-02-26 02:16:22.000000000 +0100
+++ libgui/library/looknfeel.tcl	2012-03-22 13:44:12.516985900 +0100
@@ -22,11 +22,11 @@
   # The fixed font is guaranteed not to be proportional.
   # The status font should be used in status bars and tooltips.
   if {$tcl_platform(platform) == "windows"} then {
-    define_font global/default -family windows-message
+    define_font global/default -family "Tahoma" -size 10
     # FIXME: this isn't actually a bold font...
     define_font global/bold -family windows-caption
-    define_font global/fixed -family fixedsys
-    define_font global/status -family windows-status
+    define_font global/fixed -family "Lucida Console" -size 9
+    define_font global/status -family "Tahoma" -size 10
     # FIXME: we'd like this font to update automatically as well.  But
     # for now we can't.
     array set actual [font actual windows-message]